Meta issue: #2205673: [meta] Remove all @deprecated functions marked "remove before 8.0"

Only the function exists, it's usage is removed. The usage of the function is removed in this issue: https://www.drupal.org/node/2225427, https://www.drupal.org/node/2166915

CommentFileSizeAuthor
#14 core-remove_language_load-2443783-14.patch2.64 KBgaurav_varshney
#9 core-remove_language_load-2443783-8.patch1.57 KBgaurav_varshney
#7 core-remove_language_load-2443783-7.patch1.67 KBgaurav_varshney
#2 core-remove_language_load-2443783-1.patch901 bytesfotuzlab
#1 core-remove_language_load-2443783-1.patch1.11 KBfotuzlab
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

fotuzlab’s picture

fotuzlab CreditAttribution: fotuzlab commented
FileSize
core-remove_language_load-2443783-1.patch1.11 KB
fotuzlab’s picture

fotuzlab CreditAttribution: fotuzlab commented
Status: Active » Needs review
Issue tags: +dclondon
FileSize
core-remove_language_load-2443783-1.patch901 bytes

Ignore the last patch.

daffie’s picture

daffie CreditAttribution: daffie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Needs work

Added the relevant change record. Once this lands we need to delete https://www.drupal.org/node/1323148

language_load() is still mentioned in a code comment in core/modules/config_translation/tests/src/Unit/ConfigNamesMapperTest.php

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented

This should have #2443767: Remove language_default() from bootstrap.inc and #2443767: Remove language_default() from bootstrap.inc merged in so all language_* functions are removed from bootstrap.inc

tkuldeep17’s picture

tkuldeep17 CreditAttribution: tkuldeep17 commented
Assigned: Unassigned » tkuldeep17
gaurav_varshney’s picture

gaurav_varshney CreditAttribution: gaurav_varshney commented
Assigned: tkuldeep17 » Unassigned
Status: Needs work » Needs review
FileSize
core-remove_language_load-2443783-7.patch1.67 KB

Updated Patch according to the comment #4.

Status: Needs review » Needs work

The last submitted patch, 7: core-remove_language_load-2443783-7.patch, failed testing.

gaurav_varshney’s picture

gaurav_varshney CreditAttribution: gaurav_varshney commented
FileSize
core-remove_language_load-2443783-8.patch1.57 KB

Updated Patch

gaurav_varshney’s picture

gaurav_varshney CreditAttribution: gaurav_varshney commented
Status: Needs work » Needs review
tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
Status: Needs review » Reviewed & tested by the community

Awesome, thanks!

daffie’s picture

daffie CreditAttribution: daffie commented
Status: Reviewed & tested by the community » Needs work

In comment #5 whats alexpott want is that the removal of language_default() is merged into this issue.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented

Oh yeah, missed that sorry.

gaurav_varshney’s picture

gaurav_varshney CreditAttribution: gaurav_varshney commented
Status: Needs work » Needs review
FileSize
core-remove_language_load-2443783-14.patch2.64 KB

Updated Patch According to comment #5.

daffie’s picture

daffie CreditAttribution: daffie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

daffie’s picture

daffie CreditAttribution: daffie commented
Title: Remove language_load() from bootstrap.inc » Remove language_load(), language_list() and language_default() from bootstrap.inc
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

  • catch committed 029d74f on 
    Issue #2443783 by gaurav_varshney, fotuzlab: Remove language_load(),...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.