Problem/Motivation

ConditionFormTest fails currently with PostgreSQL as database backend.

Proposed resolution

Identify and fix the failing tests.

Remaining tasks

Write patch.

User interface changes

None.

API changes

None.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bzrudi71’s picture

Status: Active » Needs review
FileSize
895 bytes

Order matters - at least for PostgreSQL. Let's see what MySQL thinks about this...

daffie’s picture

Status: Needs review » Reviewed & tested by the community

It all looks good to me.
I can confirm that the test fails for postgreSQL and with the patch the test passes for postgreSQL.
So for me it is RTBC.

catch’s picture

Status: Reviewed & tested by the community » Needs review

This looks really fragile, why does the order matter? Would prefer making the test not rely on the order.

webchick’s picture

Huh. Sorry, but could you explain this one a bit more? Why does simply changing the order of the two lines matter to PostgreSQL? (Feel free to mark back to RTBC when this is answered, though maybe we should add a code comment here as well.)

tstoeckler’s picture

FileSize
1.96 KB

I'm assuming the line that is currently failing is

    $this->assertText('The bundles are article and page', 'The form component appropriately saved the bundles.');

where the message that is output depends on the order of the bundles in the configuration.

Because the order is otherwise irrelevant - especially for this test - I think it makes more sense to instead make the output message less fragile.

Attached patch solves this by simply outputting a separate message for each bundle. Entirely untested.

daffie’s picture

Status: Needs review » Reviewed & tested by the community

It all looks good to me.
I can confirm that the test fails for postgreSQL and with the patch the test passes for postgreSQL.
I think that this is a better solution then the patch from comment #1.
So for me it is RTBC.

bzrudi71’s picture

Yep, #5 looks much better. Didn't know that we are allowed to change tests in beta phase. Thanks a tstoeckler!

  • webchick committed 6238aab on 8.0.x
    Issue #2443653 by bzrudi71, tstoeckler, daffie: PostgreSQL: Fix system\...
webchick’s picture

Status: Reviewed & tested by the community » Fixed
webchick’s picture

That's better, thanks. :) And yep, tests aren't part of the public-facing API so we can still change those.

Committed and pushed to 8.0.x. Thanks!

(Huh. D.o ate this the first time?)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.