In the method Drupal\Core\Field\FieldItemBase::getLangcode() is the variable $parent directly accessed. The method getParent() should be used. I am not sure if there is a variable $parent. All other methods is the class use the method getParent()

  /**
   * {@inheritdoc}
   */
  public function getLangcode() {
    return $this->parent->getLangcode();
  }
CommentFileSizeAuthor
#2 2442721-1.patch449 bytesmgifford
#1 2442721-1.patch449 bytesdaffie
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

daffie’s picture

Status: Active » Needs review
FileSize
449 bytes
mgifford’s picture

Re-uploading last patch for the bots.

swentel’s picture

Status: Needs review » Reviewed & tested by the community

Makes sense.

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.1.x and cherry-picked to 8.0.x. Thanks!

  • catch committed 89d52d9 on 8.1.x
    Issue #2442721 by daffie, mgifford: Direct access to the variable $...

  • catch committed ddf2d98 on
    Issue #2442721 by daffie, mgifford: Direct access to the variable $...
mgifford’s picture

It's more work, so I'm not asking that anyone remove me from this commit.

However, for the record, I took a prior patch and just uploaded it again. I had previously ensured it didn't fail when installing it on simplyTest.me, but the value in this patch was uploaded by @daffie 11 months ago.

I just nudged it along by realizing it was stuck. Fortunately @swentel RTBC'd it.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.