Move Role Constants on to a Class/Interface

index fcf4d44..3e62e4d 100644
--- a/core/includes/bootstrap.inc

--- a/core/includes/bootstrap.inc
+++ b/core/includes/bootstrap.inc

+++ b/core/includes/bootstrap.inc
@@ -82,16 +82,6 @@

@@ -82,16 +82,6 @@
 const DRUPAL_BOOTSTRAP_FULL = 3;
 
 /**
- * Role ID for anonymous users; should match what's in the "role" table.
- */
-const DRUPAL_ANONYMOUS_RID = 'anonymous';
-
-/**
- * Role ID for authenticated users; should match what's in the "role" table.
- */
-const DRUPAL_AUTHENTICATED_RID = 'authenticated';
-

diff --git a/core/lib/Drupal/Core/Session/UserSession.php b/core/lib/Drupal/Core/Session/UserSession.php
index 6af360d..bc358e0 100644

index 6af360d..bc358e0 100644
--- a/core/lib/Drupal/Core/Session/UserSession.php

--- a/core/lib/Drupal/Core/Session/UserSession.php
+++ b/core/lib/Drupal/Core/Session/UserSession.php

+++ b/core/lib/Drupal/Core/Session/UserSession.php
@@ -7,6 +7,8 @@

@@ -7,6 +7,8 @@
 
 namespace Drupal\Core\Session;
 
+use Drupal\user\RoleInterface;
+

MHHHH, I think its wrong to add a dependency of user module onto all those code.

Mabye \Drupal or AccountInterface is a better place for it?

+1 for the RoleInterface. It is where you would naturally expect it to be.

It all looks good to me.

Great work neclimdul!
Those horrible namespace constructions are gone.

It looks good to me.
Personally I would have moved the role-interface to Drupal\Core\Session\RoleInterface. But I can also live with the solution in the current patch.

There's still the question of disruption/BC layer I guess. Based on some recent issues/feedback from core committers, a normal task isn't allowed to make any API changes.

Given that it would be trivial to keep the old constants around, I'd suggest to do that and deprecate them with removal in 9.x.

Note that I've run into a few such constants in my issue to remove the forced load of .module files, including those I think, so this would help that issue.

We need to add the the fact the old constants are deprecated and will be removed in Drupal 9 to the old constants.

Added deprecated notes as per #18

+++ b/core/lib/Drupal/Core/Session/AccountInterface.php
@@ -18,6 +18,16 @@
+  const ANONYMOUS_ID = 'anonymous';
...
+  const AUTHENTICATED_ID = 'authenticated';

Can we rename them to ANONYMOUS_RID and AUTHENTICATED_RID. They are defined in the AccountInterface and the constants are related to roles not accounts.

Fully renamed the new constants as suggested in #21.

@neclimdul: And what if we rename them to AccountInterface::AUTHENTICATED_ROLE and AccountInterface::ANONYMOUS_ROLE?

Looks good to me.

+++ b/core/tests/Drupal/Tests/Core/Session/UserSessionTest.php
@@ -157,28 +158,8 @@ public function testHasPermission($permission, array $sessions_with_access, arra
-namespace {
-
-  if (!defined('DRUPAL_ANONYMOUS_RID')) {
-    /**
-     * Stub Role ID for anonymous users since bootstrap.inc isn't available.
-     */
-    define('DRUPAL_ANONYMOUS_RID', 'anonymous');
-  }
-  if (!defined('DRUPAL_AUTHENTICATED_RID')) {
-    /**
-     * Stub Role ID for authenticated users since bootstrap.inc isn't available.
-     */
-    define('DRUPAL_AUTHENTICATED_RID', 'authenticated');
-  }
-
-}

If we want to move to doing browser testing using PHPUnit then we have to remove all of this type of thing before release.

Therefore considering that this change allows for that and leaves a backwards compatibility layer in, I think that this change is good to make during beta.Thanks for adding the beta evaluation to the issue summary. Committed 59388d8 and pushed to 8.0.x. Thanks!

Edited this change record to reflect this new deprecation: https://www.drupal.org/node/1619504