Add Mink, with Goutte driver, to core

Initial patch, and tweaking the IS a bit.

Can someone please help craft an accurate commit message and add it to the top of the issue summary? There were lots more people involved over at #2232861: Create BrowserTestBase for web-testing on top of Mink and want to make sure they get credit, too. :)

I have added all the names from that issue to a commit message in IS. Here it is again:

git commit -m 'Issue #2433009 by hussainweb, grom358, daffie, larowlan, alexpott, pcambra, benjy, jibran, phenaproxima, moshe weitzman, nick_schuch: Add Mink, with Goutte driver, to core'

The very first patch in that issue has changes to composer.json, which is what this is. That is why, I am keeping all the names.

Applied composer changes and ran composer and for all intents and purposes came up with the same patch. Since this is already approved and we've got the commit message I'll bump it RTBC.

Is blocking #2232861: Create BrowserTestBase for web-testing on top of Mink.

+1 for RTBC.

The parent issue is major so should this one.

The patch in #5 changed the following file perms to 644 - whilst that is the correct permissions we should not changing them - we should be filing upstream issues.

git pre-commit check failed: file core/vendor/behat/mink-browserkit-driver/README.md should be 644 not 755
git pre-commit check failed: file core/vendor/behat/mink-goutte-driver/README.md should be 644 not 755
git pre-commit check failed: file core/vendor/symfony/dom-crawler/Symfony/Component/DomCrawler/Crawler.php should be 644 not 755
git pre-commit check failed: file core/vendor/symfony/dom-crawler/Symfony/Component/DomCrawler/Tests/CrawlerTest.php should be 644 not 755

This issue is a major task that will eventually improve testing significantly and the disruption it introduces is zero. Per https://www.drupal.org/core/beta-changes, this is a good change to complete during the Drupal 8 beta phase. Committed 2b96082 and pushed to 8.0.x. Thanks!

Sorry to be a pain, but I think this needs to be rolled back.
We ended up adding guzzle 3 back into core.
goutte should have been 2.0 (I ported it to guzzle 5 as part of #2232861: Create BrowserTestBase for web-testing on top of Mink)

To make this work correctly, we have to nominate goutte 2.0 in our composer.json so composer doesn't get a choice between 1.x and 2.x (mink-goutte-driver has require: fabot/goutte: ~1.0.4|~2.0).

So what happened was composer said - ok 1.0.4 is ok, which relies on guzzle 3.

If we nominate ~2.0 in our code, we'll get the right one.

spent 2 min testing this and ~2.0 doesn't work. there isn't a release in packagist that has the 5 support.

Sorry looked into this more that my last comment wasn't really clear enough. It doesn't work but the reason is a little more involved. Larowlan upgraded Goute to support 4.* and those changes are in the 2.0 releases of Goute but core has 5.* and the commit that raises the dependencies in their composer.json is not in any releases.

https://github.com/FriendsOfPHP/Goutte/commit/33b16e073667a3408b6a1e8c46...

We could probably use dev-master which is probably what the other patch was doing which isn't really the greatest or we can bugask very nicely for Fabien to make a release.

In the interest of unblocking things, dev-master might look like this.

The goutte browser driver to be used on top of the functional testsuite mink is not chosen because it is the browser driver that we want to use. The goutte browser driver has been chosen because it does not support javascript. And that is because the testbot does not support javascript. Of course we want functional testing with javascript enabled and that means that the testbot needs to support it. #2232861: Create BrowserTestBase for web-testing on top of Mink lays the foundation so that work on the testbot for supporting javascript can begin.

As long as functional testsuite mink does not support javascript it will not be used be drupal core. So using the goutte browser driver in a dev-master version is in my eyes not a big problem. Although I wood rather not use the dev-master release of any kind of library in drupal core, I this case it is temporary and only used as scaffolding and not actively used by drupal core.

The following libraries are added in this patch:

1. behat/mink with version v1.6.1
2. behat/mink-browserkit-driver with version v1.2.0
3. behat/mink-goutte-driver with version v1.1.0
4. fabpot/goutte with version dev-master
5. symfony/browser-kit with version v2.6.4
6. symfony/dom-crawler with version v2.6.4

All of these libraries are new in Drupal core, so problems there.

I have combined this patch with the latest patch from #2232861: Create BrowserTestBase for web-testing on top of Mink and let the testbot have a look at it. It came back green.

It all looks good to me. I have only one question left:

+++ b/core/composer.lock
@@ -2651,7 +2970,9 @@
+    "stability-flags": {
+        "fabpot/goutte": 20
+    },

Can someone explain to me what "fabpot/goutte": 20 does and why it is needed.

All of these libraries are new in Drupal core, so problems there.

What is the problem? The interdiff should show that the only change fromt he committed version is the removal of the guzzle libraries and symfony/finder and the change of the goutte version.

+++ b/core/composer.lock
@@ -2651,7 +2970,9 @@
+    "stability-flags": {
+        "fabpot/goutte": 20
+    },

Can someone explain to me what "fabpot/goutte": 20 does and why it is needed.

That is in the lock file so it was obviously added composer. If my understanding is correct the reason is I explicitly installed goutte from a dev version and core's composer.json requires stable packages. That is to say it does not have "minimum-stability": "dev",. This is flagging that this package can have a different stability from the general rule for the package. When we move to a non-dev release this would go away.

Sorry, I didn't mean to change the status because I wasn't sure what the library problem was.

It all looks good to me.

The following libraries are added in this patch:

1. behat/mink with version v1.6.1
2. behat/mink-browserkit-driver with version v1.2.0
3. behat/mink-goutte-driver with version v1.1.0
4. fabpot/goutte with version dev-master
5. symfony/browser-kit with version v2.6.4
6. symfony/dom-crawler with version v2.6.4

It gets a RTBC from me.

For the committer:

+++ b/core/composer.lock
@@ -2651,7 +2970,9 @@
+    "stability-flags": {
+        "fabpot/goutte": 20
+    },

This code is added by composer. Neclimdul and myself have the idea that the code is okay. But I would like to mention it anyway.

+1 - no extra guzzle packages and the 2.x branch of Goutte - thanks folks

Opened https://github.com/FriendsOfPHP/Goutte/issues/202

Ok, let's try this again.

Committed and pushed to 8.0.x. Thanks!

I am not sure if I'm missing something. The commit mentioned earlier only shows that core/composer.json and core/composer.lock have been changed, but the libraries themselves have not been added.

OH dang it. I committed the wrong patch. Sec.

There that should be much more betterer. :)

Yes, looks fine now. :)

@fabpot just rolled 2.0.3 so can we get a follow up to remove dev-master for Goutte?

Created followup at #2440937: Update release for Goutte driver.