Optimize DrupalComponentTest

Before patch:

..

Time: 17.86 seconds, Memory: 86.00Mb

After patch:

..

Time: 8.2 seconds, Memory: 85.50Mb

Vast improvement in speed.

Added use Drupal\Core\Access; to core/lib/Drupal/Component/Annotation/Plugin.php and the test fails as expected.
Looks good!

Added beta evaluation.

@neclimdul thank you - this has been bothering for a while. I think we should add a quick test for assertNoCoreUsage to this class. It should be simple enough by catching the php unit fail exception. See https://stackoverflow.com/questions/3917909/how-to-indicate-that-a-phpun...

Added a test using vfsStream.

The test is on the same test class as the method being tested, mostly because assertNoCoreUsage() is protected and I'm trying to catch a plane. :-) Easy enough to move to another class and mock up if it's too weird.

+++ b/core/tests/Drupal/Tests/Component/DrupalComponentTest.php
@@ -66,13 +67,73 @@ protected function findPhpClasses($dir) {
+    if ($expected_pass) {
+      $this->assertNoCoreUsage($file_uri);
+      return;
+    }
+    // We don't expect assertNoCoreUseage() to pass, so we set an expectation.
+    // We can't expect a \PHPUnit_Framework_AssertionFailedError, because
+    // PHPUnit will handle that before we get it.
+    $this->setExpectedException('\DomainException');
+    try {
+      $this->assertNoCoreUsage($file_uri);
+    }
+    catch (\PHPUnit_Framework_AssertionFailedError $e) {
+      throw new \DomainException($e->getMessage());
+    }

I think this can be simplified to something like:

    try {
      $this->assertNoCoreUsage($file_uri);
      $pass = TRUE; 
    }
    catch (\PHPUnit_Framework_AssertionFailedError $e) {
      $pass = FALSE;
    }
    $this->assertEquals($expected_pass, $pass);

With patch: Time: 6.86 seconds, Memory: 120.75Mb

Without patch: Time: 12.88 seconds, Memory: 121.75Mb

+++ b/core/tests/Drupal/Tests/Component/DrupalComponentTest.php
@@ -120,20 +120,14 @@ public function testAssertNoCoreUseage($expected_pass, $file_data) {
+    $this->assertEquals($expected_pass, $pass, "");

I bet you $10 the default message is more informative than an empty string.

Ossum. :-)

I applied the patch in #11. It still speeds everything up. It caught use statements in Component that used Core namespaces which I added to random component code. It also didn't false-error on @see for the same namespaces.

It has tests with super-duper output messages.

I'm calling it RTBC, even though I wrote some of it. Feel free to chastise me for this.

Committed a7ab29e and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation to the issue summary.