Problem/Motivation

When a user enters a path in a widget that does not match an autocomplete result and does not begin with one of the allowed characters, they receive the message:

This message is a little confusing, because it can be read as that a comma is one of the allowed characters, and also looks sort of like a string of keyboard-mashing swearing. :P

Proposed resolution

Update the message:

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Unfrozen changes Unfrozen because it only changes user interface text.
Prioritized changes The main goal of this issue is usability, so it is a prioritized change (in addition to being unfrozen).
Disruption No disruption

Remaining tasks

Patch needs review.

User interface changes

Before

After

API changes

None.

CommentFileSizeAuthor
#29 2431085-29.patch2.34 KBjofitz
#14 Add_menu_link___Site-Install.png23.83 KBxjm
#14 link-2431085-14.patch2.22 KBxjm
#8 link-error-2431085-8.patch2.16 KBpjbaert
#6 link-error-2431085-6.patch2.16 KBpjbaert
link_message_after.png26.77 KBxjm
link-error.patch2.16 KBxjm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Issue summary: View changes
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Related issues: +#2423579: Url::fromUrl('user-path:/') should throw an exception when a path component without a slash is given
geertvd’s picture

geertvd CreditAttribution: geertvd commented
Status: Needs review » Reviewed & tested by the community

Makes sense, looks more clear now.

alexpott queued link-error.patch for re-testing.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, link-error.patch, failed testing.

pjbaert’s picture

pjbaert
Primary language Dutch
CreditAttribution: pjbaert commented
Status: Needs work » Needs review
FileSize
link-error-2431085-6.patch2.16 KB

Reroll

Status: Needs review » Needs work

The last submitted patch, 6: link-error-2431085-6.patch, failed testing.

pjbaert’s picture

pjbaert
Primary language Dutch
CreditAttribution: pjbaert commented
Status: Needs work » Needs review
FileSize
link-error-2431085-8.patch2.16 KB

Added a serial comma

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented

add the serial comma recommended in our content guidelines

UGH!

That looks so very silly.

https://www.drupal.org/style-guide/content#english only applies to drupal.org, not Drupal AFAICT?

(Sorry, xjm & pjbaert :P)

geertvd’s picture

geertvd CreditAttribution: geertvd commented
Status: Needs review » Reviewed & tested by the community

Same logic was applied (and discussed) in other tickets so I think this can be RTBC
#2181653: Comma fault at database configuration overview
#2191429: Form API topic in form.inc is really out of date

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented

That looks so very silly.

Can you clarify what looks silly?

https://www.drupal.org/style-guide/content#english only applies to drupal.org, not Drupal AFAICT?

We use AE spelling and punctuation in both, but I'm more concerned about the message being confusing.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented

Yeah sorry about that, just ignore #9. (In every language I learned, that serial comma is considered absolutely not-done — you'd pretty much fail your test if you did this :P. But if this is the rule in American English, so be it. It was more of an instinctive reaction. My bad.)

The message may still be programmer-focused. We're used to quotes for indicating a string. Perhaps we should explicitly mention It should begin with one of the characters […]?

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Status: Reviewed & tested by the community » Needs review

It should begin with one of the characters […]?

That's a good idea; rerolling with that.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Issue summary: View changes
FileSize
link-2431085-14.patch2.22 KB
Add_menu_link___Site-Install.png23.83 KB

How's this?

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented

I also find myself wondering if the message is sufficient for the user to understand what they entered incorrectly, actually. The user will also get this error if they try to autocomplete something, but nothing is matched before they submit the form. Is that a concern?

The field's help text says:

Start typing the title of a piece of content to select it. You can also enter an internal path such as /node/add or an external URL such as http://example.com. Enter <front> to link to the front page.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Issue tags: +Needs usability review

Tagging for a usability review.

Bojhan’s picture

Bojhan CreditAttribution: Bojhan commented
Issue tags: -Needs usability review

I have no idea what this message is trying to tell me? What is a manually entered path? Don't I always enter that manually?

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

I have no idea what this message is trying to tell me? What is a manually entered path? Don't I always enter that manually?

Well, you often end up having something coming from an autocompletion, but i'm not sure whether its worth distinguishing these two cases in the error message.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Needs review » Needs work

I wouldn't differentiate between the two cases. Couldn't we just change it to: "Internal paths should..."? The description (cf. #15) already gives an example of what an internal path is.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

mstrelan’s picture

mstrelan CreditAttribution: mstrelan commented

We're finding some users are trying to enter external URLs without a protocol, eg. www.example.com instead of http://www.example.com. In this case they are getting confused by the message and prefixing this with a forward-slash. Perhaps the message needs to include http(s):// as a valid prefix.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ commented

I think that the use-case in #25 is something that should probably be done in a new issue.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ at Calibrate commented
Issue tags: +Needs reroll

The patch in #14 no longer applies.

jofitz’s picture

jofitz CreditAttribution: jofitz at jofitz commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
2431085-29.patch2.34 KB

Re-rolled

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and at Chapter Three commented
Status: Needs review » Reviewed & tested by the community

The description (cf. #15) already gives an example of what an internal path is.

That's a fair point. I think the patch already improves something

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 8.6.x-dev » 8.7.x-dev
Status: Reviewed & tested by the community » Fixed
Issue tags: +String change in 8.7.0

This seems like a good incremental improvement, I'm not sure if it's enough, but also don't have any ideas for more that we should do.

Committed 94098ff and pushed to 8.7.x. Thanks!

  • catch committed 94098ff on 8.7.x 
    Issue #2431085 by xjm, pjbaert, Jo Fitzgerald: Validation error for...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.