Not sure if it's a bug with devel generate or file_entity

EntityMalformedException: Missing bundle property on entity of type file. in entity_extract_ids() (line 7795 of /Users/fox/Sites/oa/drupal/includes/common.inc).

Relavent debug_backtrace:


Array
(
    [0] => Array
        (
            [file] => /Users/fox/Sites/oa/drupal/modules/field/field.attach.inc
            [line] => 191
            [function] => entity_extract_ids
            [args] => Array
                (
                    [0] => file
                    [1] => stdClass Object
                        (
                            [uri] => temporary://imagefield_PVg1dn.jpeg
                            [uid] => 1
                            [filemime] => image/jpeg
                            [filename] => imagefield_PVg1dn.jpeg
                        )

                )

        )

    [1] => Array
        (
            [file] => /Users/fox/Sites/oa/drupal/modules/field/field.attach.inc
            [line] => 1046
            [function] => _field_invoke
            [args] => Array
                (
                    [0] => delete
                    [1] => file
                    [2] => stdClass Object
                        (
                            [uri] => temporary://imagefield_PVg1dn.jpeg
                            [uid] => 1
                            [filemime] => image/jpeg
                            [filename] => imagefield_PVg1dn.jpeg
                        )

                )

        )

    [2] => Array
        (
            [file] => /Users/fox/Sites/oa/drupal/sites/all/modules/contrib/file_entity/file_entity.file.inc
            [line] => 120
            [function] => field_attach_delete
            [args] => Array
                (
                    [0] => file
                    [1] => stdClass Object
                        (
                            [uri] => temporary://imagefield_PVg1dn.jpeg
                            [uid] => 1
                            [filemime] => image/jpeg
                            [filename] => imagefield_PVg1dn.jpeg
                        )

                )

        )

    [3] => Array
        (
            [function] => file_entity_file_delete
            [args] => Array
                (
                    [0] => stdClass Object
                        (
                            [uri] => temporary://imagefield_PVg1dn.jpeg
                            [uid] => 1
                            [filemime] => image/jpeg
                            [filename] => imagefield_PVg1dn.jpeg
                        )

                )

        )

    [4] => Array
        (
            [file] => /Users/fox/Sites/oa/drupal/includes/module.inc
            [line] => 895
            [function] => call_user_func_array
            [args] => Array
                (
                    [0] => file_entity_file_delete
                    [1] => Array
                        (
                            [1] => stdClass Object
                                (
                                    [uri] => temporary://imagefield_PVg1dn.jpeg
                                    [uid] => 1
                                    [filemime] => image/jpeg
                                    [filename] => imagefield_PVg1dn.jpeg
                                )

                        )

                )

        )

    [5] => Array
        (
            [file] => /Users/fox/Sites/oa/drupal/includes/file.inc
            [line] => 1292
            [function] => module_invoke_all
            [args] => Array
                (
                    [0] => file_delete
                    [1] => stdClass Object
                        (
                            [uri] => temporary://imagefield_PVg1dn.jpeg
                            [uid] => 1
                            [filemime] => image/jpeg
                            [filename] => imagefield_PVg1dn.jpeg
                        )

                )

        )

    [6] => Array
        (
            [file] => /Users/fox/Sites/oa/drupal/includes/file.inc
            [line] => 1078
            [function] => file_delete
            [args] => Array
                (
                    [0] => stdClass Object
                        (
                            [uri] => temporary://imagefield_PVg1dn.jpeg
                            [uid] => 1
                            [filemime] => image/jpeg
                            [filename] => imagefield_PVg1dn.jpeg
                        )

                )

        )

    [7] => Array
        (
            [file] => /Users/fox/Sites/oa/drupal/sites/all/modules/contrib/devel/devel_generate/image.devel_generate.inc
            [line] => 40
            [function] => file_move
            [args] => Array
                (
                    [0] => stdClass Object
                        (
                            [uri] => temporary://imagefield_PVg1dn.jpeg
                            [uid] => 1
                            [filemime] => image/jpeg
                            [filename] => imagefield_PVg1dn.jpeg
                        )

                    [1] => public:///imagefield_PVg1dn.jpeg
                    [2] => 1
                )

        )

    [8] => Array
        (
            [file] => /Users/fox/Sites/oa/drupal/sites/all/modules/contrib/devel/devel_generate/devel_generate.fields.inc
            [line] => 91
            [function] => _image_devel_generate
CommentFileSizeAuthor
#5 2429787-file-generate-unmanaged-move.patch3 KBDave Reid
#3 2429787-file-generate-unmanaged-move.patch2.78 KBDave Reid
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hefox’s picture

hefox CreditAttribution: hefox commented
Related issues: +#2176051: drupal_tempname doesn't give a unique file name for public when called for temp

Question if file_move is suppose to be called on a temp file

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer commented
Title: Fatal error during devel generate when file_move called with object without bundle » File generation should use file_unmanaged_move() instead of file_move() before the file object is saved
Project: File Entity (fieldable files) » Devel
Version: 7.x-2.x-dev » 7.x-1.x-dev
Component: Code » devel_generate
Category: Feature request » Bug report

Strange, devel should be using file_unmanaged_move(), not file_move(). Because file_move() should only be used for managed files (that have a file ID already).

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer commented
Status: Active » Needs review
FileSize
2429787-file-generate-unmanaged-move.patch2.78 KB
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer commented

This also fixes the issue with invalid parameter to file_move() from #1210300: Devel Generate produces errors on file

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer commented
FileSize
2429787-file-generate-unmanaged-move.patch3 KB

Returns FALSE in case file_unmanaged_move() returns FALSE.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer commented

I've tested this locally as well.

  • Dave Reid committed 566318b on 7.x-1.x 
    Issue #2429787 by Dave Reid: Fixed file generation should use...
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer commented
Status: Needs review » Fixed
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer commented

Filed a bug in D8 core as well: #2550973: ImageItem::generateSampleValue() should use file_unmanaged_move() before saving the file

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.