This issue is part of #1333730: [Meta] PHP DOM (libxml2) misinterprets HTML5.

In this issue will the masterminds/html5 library be added to Drupal 8 core. This is necessary for the filter system and for the testing system. The use of this library for both the filter system and the testing system will be added in follow-up issues. This library has been chosen, because it does what we want and is ready to be used. All the alternatives have problems with either or both of them.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue priority Major because the bug has many repercussions on filters using the HTML filter, and under some circumstances could result in an invalid DOM. Not critical because it does not render the HTML filter unusable. Also the testing system needs HTML5 support to test HTML5 code.
Prioritized changes The main goal of this issue is a bugfix to for HTML5 support, which is part of the Drupal 8 product.

Commit credits
Please give commit credits to all who have worked on the parent issue (#1333730: [Meta] PHP DOM (libxml2) misinterprets HTML5).

CommentFileSizeAuthor
#13 2429363-13.patch429.71 KBdaffie
#13 2429363-13-review-do-not-test.patch6.17 KBdaffie
#8 2429363-8.patch429.65 KBdaffie
#8 2429363-8-review-do-not-test.patch6.12 KBdaffie
#7 2429363-7-review-do-not-test.patch6.13 KBdaffie
#7 2429363-7.patch429.66 KBdaffie
#6 2429363-6.patch431.22 KBdaffie
#6 2429363-6-review-do-not-test.patch7.69 KBdaffie
#2 2429363-2-review-do-not-test.patch6.13 KBdaffie
#2 2429363-2.patch429.71 KBdaffie
#1 2429363-1.patch349.44 KBdaffie
#1 2429363-1-do-not-test.patch7.47 KBdaffie
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

daffie’s picture

daffie CreditAttribution: daffie commented
Status: Active » Needs review
FileSize
2429363-1-do-not-test.patch7.47 KB
2429363-1.patch349.44 KB
daffie’s picture

daffie CreditAttribution: daffie commented
FileSize
2429363-2.patch429.71 KB
2429363-2-review-do-not-test.patch6.13 KB

#2433009: Add Mink, with Goutte driver, to core has landed. So we need a re-roll.

daffie queued 1: 2429363-1.patch for re-testing.

daffie’s picture

daffie CreditAttribution: daffie commented

#2433009: Add Mink, with Goutte driver, to core has been reverted. For reviewing use the patch from the first comment.

daffie’s picture

daffie CreditAttribution: daffie commented
Issue summary: View changes
daffie’s picture

daffie CreditAttribution: daffie commented
FileSize
2429363-6-review-do-not-test.patch7.69 KB
2429363-6.patch431.22 KB

The patch from comment #1 adds masterminds/html5 version 1.0.7 to drupal core. The latest stable release is version 2.1.0.

daffie’s picture

daffie CreditAttribution: daffie commented
FileSize
2429363-7.patch429.66 KB
2429363-7-review-do-not-test.patch6.13 KB

#2433009: Add Mink, with Goutte driver, to core has re-landed again. So re-rolling the patch again. :(

daffie’s picture

daffie CreditAttribution: daffie commented
FileSize
2429363-8-review-do-not-test.patch6.12 KB
2429363-8.patch429.65 KB

#2440937: Update release for Goutte driver has landed. Re-rolling is so much FUN!!!!

mrjmd’s picture

mrjmd CreditAttribution: mrjmd commented
Status: Needs review » Reviewed & tested by the community

This looks good to me.

I did a quick functional test as well, I applied the patch here as well as the patch from #2441373: Upgrade tests to HTML5 and ran the test: everything passed.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Assigned: Unassigned » Dries

Technically a new library, so this goes to Dries.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 8: 2429363-8.patch, failed testing.

Dries’s picture

Dries CreditAttribution: Dries commented
Assigned: Dries » Unassigned

I'm ok with adding this library. It seems necessary to resolve the bug. :-)

daffie’s picture

daffie CreditAttribution: daffie commented
Status: Needs work » Needs review
FileSize
2429363-13-review-do-not-test.patch6.17 KB
2429363-13.patch429.71 KB
mrjmd’s picture

mrjmd CreditAttribution: mrjmd commented
Status: Needs review » Reviewed & tested by the community

Looks good :).

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 41dfab8 and pushed to 8.0.x. Thanks!

  • alexpott committed 41dfab8 on 8.0.x 
    Issue #2429363 by babruix, twistor, filijonka, sun, Mile23, daffie, Wim...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.