Follow-up to #2403269: Update to jQuery UI 1.11.2

Problem/Motivation

Libraries in core that are not the latest stable release of the library need to be updated prior to the release of 8.0.0, as per #2203431: [meta] Various asset (JavaScript) libraries have to be updated to a (minified) stable release prior to 8.0.0

Proposed resolution

Update the jQuery UI library to the latest stable release: 1.11.4

Remaining tasks

  • Replace the jQuery UI library files in /core/assets/vendor/jquery.ui/ with the 1.11.4 release from jQuery GitHub repo
  • Minify JS files
  • Perform manual testing

User interface changes

None

API changes

None

CommentFileSizeAuthor
#7 update-jquery-ui-2427649-7.patch531.56 KBhampercm
#2 update-jquery-ui-2427649.patch530.39 KBhampercm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hampercm’s picture

hampercm CreditAttribution: hampercm commented
Assigned: Unassigned » hampercm
Issue summary: View changes

From the changelog on jqueryui.com, jQuery UI 1.11.3 appears to be a bug-fix-only release, so upgrading from 1.11.2 to 1.11.3 shouldn't have any impacts on Drupal.

I'll hammer a patch out quickly, when I have the opportunity.

hampercm’s picture

hampercm CreditAttribution: hampercm commented
Assigned: hampercm » Unassigned
Status: Active » Needs review
Issue tags: +Needs manual testing
Parent issue: » #2203431: [meta] Various asset (JavaScript) libraries have to be updated to a (minified) stable release prior to 8.0.0
FileSize
update-jquery-ui-2427649.patch530.39 KB

This patch updates the jQuery UI assets to 1.11.3

I've performed some manual testing on all functionality I know of that utilizes jQuery UI: dialogs, CKEditor admin, and Quick Edit positioning. Looks good :)

hampercm’s picture

hampercm CreditAttribution: hampercm commented
Issue summary: View changes

jibran queued 2: update-jquery-ui-2427649.patch for re-testing.

hampercm’s picture

hampercm CreditAttribution: hampercm commented
Title: Update to jQuery UI 1.11.3 » Update to jQuery UI 1.11.4
Assigned: Unassigned » hampercm
Issue summary: View changes
Status: Needs review » Active

jQuery UI 1.11.4 has been released--another bug-fix-only release. Updating this issue to match.

I'll hammer out a new patch shortly...

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
Assigned: hampercm » Unassigned
Status: Active » Needs work
Issue tags: -blocker

Still working on it?

hampercm’s picture

hampercm CreditAttribution: hampercm commented
Status: Needs work » Needs review
FileSize
update-jquery-ui-2427649-7.patch531.56 KB

Sorry about that; this issue had slipped my mind.

Here's the patch to bring the jQuery UI asset up to 1.11.4. I've once again tested dialogs, CKEditor admin, and Quick Edit positioning. Everything looked good to me.

I also updated the license info in core.libraries.yml, as jQuery UI appears to have shifted to a Public Domain license according to their GitHub repo.

stefan.r’s picture

stefan.r CreditAttribution: stefan.r commented
Status: Needs review » Needs work

those tabs should be spaces :)

stefan.r’s picture

stefan.r CreditAttribution: stefan.r commented
Status: Needs work » Needs review

Actually that was not a core file so never mind!

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs manual testing

Sweet. Dialogs still working fine, our custom positioning stuff too, nothing to complain about.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick at Acquia commented
Status: Reviewed & tested by the community » Fixed

Awesome, thanks for the manual testing.

Committed and pushed to 8.0.x. Thanks!

  • webchick committed cf37ccf on 8.0.x 
    Issue #2427649 by hampercm, nod_: Update to jQuery UI 1.11.4

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.