Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
the .indentation
class is required for table drag to work, but the class is not prefixed with .js-
as our css documentation requires & it also makes it recognizable for the themer, that this class is not used for pretty colors ;)
formatting https://www.drupal.org/node/1887918#formatting
Proposed resolution
rename .indentation
to .js-indentation
Remaining tasks
* screenshots of table drag maanger (theres on on the menu admin)
* seven theme
* stark theme
User interface changes
API changes
Comment | File | Size | Author |
---|---|---|---|
#11 | indentation-class-js-prefix-11.patch | 10.47 KB | brahmjeet789 |
#5 | post-patch.gif | 427.87 KB | mortendk |
#3 | indentation-class-js-prefix-2.diff | 11.72 KB | mortendk |
indentation-class-js-prefix.diff | 10.39 KB | mortendk | |
Comments
Comment #1
mortendk CreditAttribution: mortendk commentedgotowork bot
Comment #3
mortendk CreditAttribution: mortendk commentedshould fix the test errors
Comment #4
mortendk CreditAttribution: mortendk commentedComment #5
mortendk CreditAttribution: mortendk commentedanim gif to show theres no regression
Comment #6
mortendk CreditAttribution: mortendk commentedComment #7
LewisNymanComment #8
mortendk CreditAttribution: mortendk commented2 mentions of the
shold be corrected
Comment #9
DickJohnson CreditAttribution: DickJohnson commentedDid some grepping and found these.
Comment #10
mortendk CreditAttribution: mortendk commented@dickjohnson looks like your casche wasnt cleared & you found old data in tabledrag.js
Comment #11
brahmjeet789 CreditAttribution: brahmjeet789 commentedHi @mortendk i think you missed the file TaxonomyTermIndentationTest.php i have changed it please check is it fine or not
Comment #12
LewisNymanI manually tested this patch in Classy and Seven and it works as expected. I also looked for any missed instances of indentation that we missed and couldn't find any.
Comment #14
webchickMarkup/CSS changes are allowed during beta.
Committed and pushed to 8.0.x. Thanks!
Comment #16
jibranPublished the change notice.