Problem/Motivation
It's common for performance-related modules to add new tabs to /admin/config/development/performance
. Unfortunately, that doesn't work unless that route itself defines a "Performance" tab.
The only way D8 contrib modules can fix this, is by declaring it on behalf of core: #2425093: Purge declares 'Performance' task on behalf of system module: smells fishy. That's not nice. Let's fix that.
Proposed resolution
Declare system.performance_settings
in system.links.task.yml
. Note that the tab doesn't even show up! So no UI changes. It only shows up if contrib modules declare additional tasks, with this tab as the parent.
Remaining tasks
None.
User interface changes
None.
API changes
None.
Comment | File | Size | Author |
---|---|---|---|
#9 | 2425101-1.patch | 584 bytes | mgifford |
#1 | 2425101-1.patch | 584 bytes | Wim Leers |
Comments
Comment #1
Wim LeersComment #2
Wim LeersComment #4
Wim LeersWTF, testbot?
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Failed to run tests: failed attempting to get list of tests from run-tests.sh.
Comment #6
Wim LeersGreen. Better :)
Comment #7
dawehnerDoes that mean we have to think more about local tasks in general? Doesn't each bit, for example the media parts, have similar problems?
Comment #8
Wim LeersIt's quite possible this is a more widespread problem. But this seems the only solution for now?
AFAIK this was not a problem in D7. Was it because we declared all of the top-level "admin things" as
MENU_LOCAL_TASK
, whereas now we have to list all of them "manually" here?Comment #9
mgiffordRe-uploading last patch for the bots.
Comment #10
dawehnerHonestly I don't see that as much of a problem. We can fix core by time and even multiple contrib modules would not really interfere with each other.
Comment #15
jhedstromAnything left to do here? Seems RTBC to me, and if it is more of a widespread issue, follow-ups can be made as @dawehner suggests in #10.
Comment #16
saranya ashokkumar CreditAttribution: saranya ashokkumar at UniMity Solutions Pvt Limited commentedI think this can move to RTBC. This feature will be useful for other modules, If it moved.
Comment #17
saranya ashokkumar CreditAttribution: saranya ashokkumar at UniMity Solutions Pvt Limited commentedComment #19
Wim Leers🎉 Created 12 Feb 2015 at 12:40 CET, fixed today, 2.5 years later. Glad we're not just losing sight of these small incremental improvements!
Comment #20
catchCommitted a52185c and pushed to 8.5.x. Thanks!\n