As requested by @jibran in #2107243-45: Decouple entity reference selection plugins from field definitions, this is a followup that makes Drupal\Core\Entity\Plugin\EntityReferenceSelection\SelectionBase::buildEntityQuery() a protected method.

CommentFileSizeAuthor
#1 2421849.patch3.96 KBamateescu
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

amateescu’s picture

amateescu CreditAttribution: amateescu commented
Status: Active » Needs review
FileSize
2421849.patch3.96 KB
geertvd’s picture

geertvd CreditAttribution: geertvd commented
Status: Needs review » Reviewed & tested by the community

Looks good, I don't see any reason not to put this to RTBC

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed under the followup proviso in the beta policy. Committed 03b7423 and pushed to 8.0.x. Thanks!

  • alexpott committed 03b7423 on 8.0.x 
    Issue #2421849 by amateescu: Make SelectionBase::buildEntityQuery()...
jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented

What about SelectionBase::entityQueryAlter() we can also make it protected?

amateescu’s picture

amateescu CreditAttribution: amateescu commented

A quick search through the code would show that it's used outside the selection classes, in entity_reference_query_entity_reference_alter() :)

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented

Thank you @amateescu.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.