Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Making critical because without this we can't do #2206501: Remove dependency on Drush from test reviews.
The introduction of the parent-free test runner did not test the --list command which only prints out a list of tests and then exits.
With the attached patch running php ./core/scripts/run-tests.sh --url http://drupal8.core/ --all --list produces the expected output ofhttps://privatepaste.com/73ee188e3f.
The relevant code from PIFR is:
// Get test info for use by test_info_parse().
if (!$this->exec(PIFR_CLIENT_PHP . ' ./' . $run_tests . ' --php ' . PIFR_CLIENT_PHP . ' --url ' . $url . ' ' . $test_list . ' --list')) {
$this->set_error(array('@reason' => t('failed attempting to get list of tests from run-tests.sh')));
return;
}
Once committed this will work with sun's patch on #2206501: Remove dependency on Drush from test reviews. It works against HEAD atm because at this point a parent site exists. And committing this patch will not break HEAD.
The patch works by moving the --list processing above simpletest_script_setup_database(TRUE);.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | d8.run-tests.patch | 1.11 KB | alexpott |
| #2 | 2421335.2.patch | 377 bytes | alexpott |
| d8.run-tests.patch | 1.11 KB | alexpott | |
Comments
Comment #2
alexpottAn even simpler fix... wtf, testbot.
Comment #3
alexpottThe --clean and --list commands don't work together anyways - they both use
exit;- oh run-tests.sh what happened to the single responsibility principle?Comment #7
alexpottSo the bot #2753 seemingly still had #2206501: Remove dependency on Drush from test reviews applied which was a good thing because it allowed me to find out another bug in that patch. But this also means the patch in #0 is good to go. Re-uploading.
Comment #8
BerdirNote: I manually disabled #2753.
Comment #9
alexpottComment #10
BerdirI've confirmed manually that this works, patch just moves the existing code up, looks fine and unblocks #2206501: Remove dependency on Drush from test reviews.
Comment #11
alexpottThis is critical because not having a dependency on Drush for testbots to work will help us get to 0 criticals faster.
Comment #13
catchCommitted/pushed to 8.0.x, thanks!