Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
The responsive image config entity type's schema reimplements a lot of what the config_entity
type already provides. Of course, that type was only added after responsive image module's schema was created, so that's understandable.
Proposed resolution
Use the config_entity
type.
Remaining tasks
Do it.
User interface changes
None.
API changes
TBD (nothing actually changes, but the types do change, so…)
Comment | File | Size | Author |
---|---|---|---|
#7 | 2419857.7.patch | 2.07 KB | alexpott |
Comments
Comment #1
Wim LeersNot sure about the priority, but feels like this is at least major.
Comment #3
Wim LeersHehe, oops, this patch is relative to #2260061: Responsive image module does not support sizes/picture polyfill 2.2. Will reroll against HEAD later unless somebody beats me to it; easy to reroll!
Comment #4
Wim LeersComment #5
alexpottThis is a bug tbh. Really nice find. I wonder if any other config entities do this. Yep core.entity_view_mode.*.* - it is the only other.
Let's fix that here too.
Comment #6
BerdirWe discussed the upgrade path tag, I don't think it is needed, nothing will break, the order might change if you export them again, and with #2361775: Third party settings dependencies cause config entity deletion, there will be a new top level key, but that is just an adition.
Comment #7
alexpottNew patch
Comment #8
Wim LeersSo… #2361775: Third party settings dependencies cause config entity deletion landed. Not sure if that affects anything.
This is so braindead simple that I'm forced to RTBC.
Comment #9
catchVery nice one. Committed/pushed to 8.0.x, thanks!
Comment #11
Gábor HojtsyNice, yay!