I'd like to add some static caching to menu block configuration, and improve the way the default values are handled, so they're only defined in one place.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Dave Reid’s picture

Status: Active » Needs review
FileSize
7.46 KB
Dave Reid’s picture

FileSize
7.42 KB

Without my test export function.

Dave Reid’s picture

More re-use of menu_block_default_config() in menu_block_uninstall() and menu_block_delete().

dblue’s picture

Tested #3, works for me, looks good. Toward the top of menu_block_get_config() you might swap the positions of

  if (!isset($exported)) {
    $exported = menu_block_get_exported_blocks();
  }

and

  if (!isset($delta)) {
    return $defaults;
  }
Dave Reid’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
9.26 KB

Fixed #4 and also missing 'delta' value from the config array.

Dave Reid’s picture

Status: Reviewed & tested by the community » Fixed

Committed #5 to 7.x-2.x.

  • Dave Reid committed ebc7ef4 on 7.x-2.x
    Issue #2419725 by Dave Reid: Refactored menu_block_get_config().
    

Status: Fixed » Needs work

The last submitted patch, 5: 2419725-refactor-menu-block-get-config.patch, failed testing.

Dave Reid’s picture

Status: Needs work » Fixed

  • Dave Reid committed ebc7ef4 on 7.x-3.x
    Issue #2419725 by Dave Reid: Refactored menu_block_get_config().
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.