Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I'd like to add some static caching to menu block configuration, and improve the way the default values are handled, so they're only defined in one place.
Comment | File | Size | Author |
---|---|---|---|
#5 | 2419725-refactor-menu-block-get-config.patch | 9.26 KB | Dave Reid |
#3 | 2419725-refactor-menu-block-get-config.patch | 9.08 KB | Dave Reid |
#2 | 2419725-refactor-menu-block-get-config.patch | 7.42 KB | Dave Reid |
Comments
Comment #1
Dave ReidComment #2
Dave ReidWithout my test export function.
Comment #3
Dave ReidMore re-use of menu_block_default_config() in menu_block_uninstall() and menu_block_delete().
Comment #4
dblue CreditAttribution: dblue commentedTested #3, works for me, looks good. Toward the top of menu_block_get_config() you might swap the positions of
and
Comment #5
Dave ReidFixed #4 and also missing 'delta' value from the config array.
Comment #6
Dave ReidCommitted #5 to 7.x-2.x.
Comment #9
Dave Reid