Fix incorrect @covers in PHPUnit tests

+++ b/core/modules/views/tests/src/Unit/PluginBaseTest.php
@@ -46,9 +46,8 @@ protected function setUp() {
    *   Whether to unpack all options.
    *

@@ -289,6 +287,7 @@ public function providerTestSetOptionDefault() {
    * Tests filterByDefinedOptions().
    *

+++ b/core/modules/views/tests/src/Unit/ViewExecutableUnitTest.php
@@ -119,7 +119,7 @@ public function testBuildThemeFunctions() {
    * Tests the generateHandlerId method().
    *

@@ -131,7 +131,7 @@ public function testGenerateHandlerId() {
    * Tests the addHandler method().
    *

@@ -217,7 +217,7 @@ public function testAddHandlerWithEntityField() {
    * Tests attachDisplays().
    *

+++ b/core/tests/Drupal/Tests/Component/Plugin/PluginBaseTest.php
@@ -19,9 +19,7 @@ class PluginBaseTest extends UnitTestCase {
    * Tests the getPluginId method.
    *

@@ -49,8 +47,7 @@ public function providerTestGetPluginId() {
    * Tests the getBaseId method.
    *

@@ -80,8 +77,7 @@ public function providerTestGetBaseId() {
    * Tests the getDerivativeId method.
    *

@@ -109,7 +105,7 @@ public function providerTestGetDerivativeId() {
    * Tests the getPluginDefinition method.
    *

+++ b/core/tests/Drupal/Tests/Core/Batch/PercentagesTest.php
@@ -24,8 +24,7 @@ class PercentagesTest extends UnitTestCase {
    * Tests the format() function.
    *

+++ b/core/tests/Drupal/Tests/Core/DrupalKernel/ValidateHostnameTest.php
@@ -20,7 +20,7 @@ class ValidateHostnameTest extends UnitTestCase {
    * Tests hostname validation.
    *

+++ b/core/tests/Drupal/Tests/Core/Menu/LocalTaskDefaultTest.php
@@ -217,8 +219,7 @@ public function providerTestGetWeight() {
    * Tests the getWeight method.
    *

@@ -231,8 +232,8 @@ public function testGetWeight($plugin_definition, $plugin_id, $expected_weight)
    * Tests getActive/setActive() method.
    *

@@ -294,7 +297,7 @@ public function testGetTitleWithTitleArguments() {
    * Tests the getOption method.
    *

I think that these lines can be removed.

+++ b/core/tests/Drupal/Tests/Core/Routing/RouteMatchTest.php
@@ -30,7 +30,6 @@ protected function getRouteMatch($name, Route $route, array $parameters, array $
-   * @covers \Drupal\Core\Routing\NullRouteMatch

I am not sure what to do with this line. We are also testing this other class. Can we change @covers to @see? @Mile23: If you have a better idea please let me know.

Good work Mile23! And thanks for explaining the NullRouteMatch testing.

Looks all good to me.
The documentation is a lot better for unittesting.
There are also two function which are renamed. Both are test-functions and they are allowed for beta-changes.
So it gets a RTBC from me.

#2409587: Incorrect documentation for @covers has landed. Starting a re-test to see if there are any problems.

If so, then its broken again because I couldn't run coverage tests. Working on it.

Interdiff is fairly self explanatory. Trickiest one is the routematch base test which was claiming to cover methods that only exist on the routematch, not methods publicly on the interface which is what its used for. Clarified the test documentation and removed the coverage. If we want to test that method we can put something in the routematch test explicitly.

Actually #2409587: Incorrect documentation for @covers is what broke the base test. We can just revert those changes.

1. +++ b/core/tests/Drupal/Tests/Core/Menu/ContextualLinkDefaultTest.php
   @@ -16,6 +16,7 @@
     * Tests the contextual link default class.
     *
   

   These lines can be removed.

2. +++ b/core/tests/Drupal/Tests/Core/Routing/RouteMatchBaseTest.php
   @@ -15,7 +15,7 @@
   - * Base test class for testing the RouteMatch object.
   + * Base test class for testing classes implementing the route match interface.
   
   @@ -102,7 +102,7 @@ public function testGetRouteObject(RouteMatchInterface $route_match, Route $rout
       * @covers ::getParameter
   
   @@ -116,7 +116,7 @@ public function testGetParameter(RouteMatchInterface $route_match, Route $route,
       * @covers ::getParameters
   
   @@ -125,7 +125,7 @@ public function testGetParameters(RouteMatchInterface $route_match, Route $route
       * @covers ::getRawParameter
   
   @@ -139,7 +139,7 @@ public function testGetRawParameter(RouteMatchInterface $route_match, Route $rou
       * @covers ::getRawParameters
   

   Should we not use @coversDefaultClass for this. We have @covers in this class without a class reference. From which class are these methods?

Needed a re-roll after #2422019: Don't use reflection for parsing test annotations. No changes, just resolved a merge conflict because it added some annotations to some tests. Seems like we could probably RTBC this and just move forward? This fixes the issue of coverage being broken and any cleanups can come later.

For me it is almost RTBC. I have only two nitpicks left:

1. +++ b/core/tests/Drupal/Tests/Core/Config/Entity/EntityDisplayBaseTest.php
   @@ -50,7 +50,7 @@ public function testGetOriginalMode() {
   -   * @covers ::getDisplayBundle()
   +   * @covers ::getTargetBundle
   ...
      public function testGetDisplayBundle() {
   
   @@ -61,7 +61,7 @@ public function testGetDisplayBundle() {
   -   * @covers ::setDisplayBundle()
   +   * @covers ::setTargetBundle
   ...
      public function testSetDisplayBundle() {
   

   Can we also rename the test functions.

2. +++ b/core/tests/Drupal/Tests/Core/Plugin/Discovery/ContainerDerivativeDiscoveryDecoratorTest.php
   @@ -17,7 +17,7 @@
       *
       * @see \Drupal\Core\Plugin\Discovery\ContainerDerivativeDiscoveryDecorator::getDerivativeFetcher().
   

   These lines can be removed.

It all looks good to me.
It is all about documentation about tests and some renaming of tests. So no problem with beta changes.
It is RTBC for me.

I'd say this was a straight re-roll but it was actually sort of an ugly merge conflict. It was mostly just a bunch of tests getting added above one of our chunks but because of that I'm going to mark it back NR just so someone can give it a once over and make sure I didn't miss anything.

Cause: #2409209: Replace all _url() calls beside the one in _l()

Conflicts:
core/modules/views/tests/src/Unit/ViewExecutableTest.php

@neclimdul: Can you add an interdiff.txt file. It helps with reviewing.

It all looks good to me. Again.
It is all about documentation about tests and some renaming of tests. So no problem with beta changes.
It is RTBC for me.

Resolving conflicts like this I apply the patch at the last working commit and then merge(https://gist.github.com/neclimdul/d611b5033c6d302fab7e). You can't really interdiff a merge though, you get all of the changes you are merging and not anything useful for review. Sorry.

Thanks for taking the time to review it!

I'm changing the component. Although this is technically documentation, it seems like the test scripts use this?

Happily. No changes again so no change in status.

@jyotisankar are you trolling for commit credit?

#31 is wrong, #29 is the patch to commit.

Suggested commit credit:

Issue #2418237 by Mile23, neclimdul: The Mother Of All @covers Issues

Based on the comment number in the patch name and the fact out patches are the same with different metadata it looks like it was an honest mistake and a x-post.

A reminder its a good idea to refresh before posting a patch if you didn't assign it to yourself :-D

Due #34 I've given @jyotisankar a commit credit. I've committed the patch in #29 due to the fact that

diff --git a/core/modules/views/tests/src/Unit/ViewExecutableTest.php b/core/modules/views/tests/src/Unit/ViewExecutableTest.php
old mode 100644
new mode 100755

Documentation is not frozen in beta. Committed 0bab86f and pushed to 8.0.x. Thanks!