Noticed an occurrence of "the the" in the help documentation, so grepped for it in the code base and found quite a few. This patch touches lots of files.

All of them, except one, just change "the the" to "the"

One of them also tidys up a little extra grammar. Will highlight that in a follow up comment.

CommentFileSizeAuthor
#12 docs-tidy-thethe-to-the-d6-2417983-12.patch1019 bytesjacob.embree
#6 docs-tidy-thethe-to-the-d7-2417983-6.patch7.42 KBjacob.embree
docs-tidy-thethe-to-the.patch21.45 KBkattekrab
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kattekrab’s picture

kattekrab CreditAttribution: kattekrab commented 
+++ b/core/modules/locale/src/Tests/LocaleImportFunctionalTest.php
@@ -525,8 +525,8 @@ public function getCustomOverwritePoFile() {
-    // Croatian (code hr) is one the the languages that have a different
-    // form for the full name and the abbreviated name for the month May.
+    // Croatian (code hr) is one of the languages that have a different
+    // form for the full name and the abbreviated name for the month of May.

This is the only change which isn't just removing an extra "the"

Croatian (code hr) is one the the languages that have a different
form for the full name and the abbreviated name for the month May.

Croatian (code hr) is one of the languages that have a different
form for the full name and the abbreviated name for the month of May.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quick fix

Nice catch.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Priority: Normal » Minor
Status: Reviewed & tested by the community » Fixed

Documentation fixes are not prevented during the beta. Committed a60a577 and pushed to 8.0.x. Thanks!

  • alexpott committed a60a577 on 8.0.x 
    Issue #2417983 by kattekrab: Change docs instances of "the the" to "the"
David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein commented
Version: 8.0.x-dev » 7.x-dev
Status: Fixed » Patch (to be ported)
Issue tags: +Needs backport to D7

Worth fixing in Drupal 7 also, although might be a totally different patch :)

jacob.embree’s picture

jacob.embree CreditAttribution: jacob.embree commented
Status: Patch (to be ported) » Needs review
Issue tags: +Novice
FileSize
docs-tidy-thethe-to-the-d7-2417983-6.patch7.42 KB

Some things needed to be rewrapped.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Reviewed & tested by the community

Patch looks great to me, thanks!

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented

Note: It does make two code string changes, but they're in tests.

dcam’s picture

dcam CreditAttribution: dcam commented

Looks good to me too. RTBC+1

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x. Thanks again!

  • jhodgdon committed ea85d7c on 7.x 
    Issue #2417983 by jacob.embree: Change docs instances of "the the" to "...
jacob.embree’s picture

jacob.embree CreditAttribution: jacob.embree commented
Status: Fixed » Needs review
Issue tags: -Needs backport to D7 +Needs backport to D6
FileSize
docs-tidy-thethe-to-the-d6-2417983-12.patch1019 bytes

Want one for D6?

jacob.embree’s picture

jacob.embree CreditAttribution: jacob.embree commented
Version: 7.x-dev » 6.x-dev

Status: Needs review » Needs work

The last submitted patch, 12: docs-tidy-thethe-to-the-d6-2417983-12.patch, failed testing.

Status: Needs work » Needs review

jacob.embree queued 12: docs-tidy-thethe-to-the-d6-2417983-12.patch for re-testing.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Reviewed & tested by the community

Sure... doubt it will get committed at this point, but the patch is fine.

  • alexpott committed a60a577 on 8.1.x 
    Issue #2417983 by kattekrab: Change docs instances of "the the" to "the"
  • alexpott committed 720f586 on 8.1.x
    Issue #2453311 by David_Rothstein, TravisCarden, Dom., rpayanm: Issue #...
jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon at Poplar ProductivityWare for Drupal Association commented
Status: Reviewed & tested by the community » Fixed

I am cleaning up old 6.x documentation issues. At this point, we are not spending effort fixing them. Sorry.

ALthough... This one has an RTBC patch so I guess I will go ahead and commit it. Thanks!

  • jhodgdon committed a101fcc on 6.x 
    Issue #2417983 by jacob.embree, kattekrab: Change docs instances of "the...
kattekrab’s picture

kattekrab CreditAttribution: kattekrab at Creative Contingencies commented

Ha!

Thanks @jhodgdon :)

kattekrab’s picture

kattekrab CreditAttribution: kattekrab at Creative Contingencies commented
Issue tags: -Quick fix, -Needs backport to D6, -Novice

removed tags.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.