Support from Acquia helps fund testing for Drupal Acquia logo

Comments

miguelc303’s picture

I did a patch to enable end user to migrate Customs Blocks from Drupal 7 to Drupal 8.

benjy’s picture

miguelc303’s picture

Added organization support to Anexus IT

phenaproxima’s picture

Status: Active » Postponed

Postponing on #2384567: Migration Files for Drupal 7 Text Formats & Filters, since this migration depends on text formats and I'd prefer not to merge this patch into that issue.

phenaproxima’s picture

quietone’s picture

moved files to block_content module.

phenaproxima’s picture

Status: Postponed » Needs review

This is unblocked now, since text format migration has landed.

phenaproxima’s picture

Project: IMP » Drupal core
Version: » 8.0.x-dev
Component: Code » migration system

Changing the project.

quietone’s picture

Status: Needs review » Needs work
Issue tags: +Needs tests
phenaproxima’s picture

Status: Needs work » Needs review
Issue tags: -Needs tests
FileSize
11.28 KB
mikeryan’s picture

FileSize
4.79 KB

Non-test diffs between D6 and D7.

mikeryan’s picture

Status: Needs review » Needs work
  1. +++ b/core/modules/block_content/migration_templates/d7_block_content_body_field.yml
    @@ -1,25 +1,31 @@
    +  plugin: embedded_data
    

    Can we justify changing the D6 migration to match here?

  2. +++ b/core/modules/block_content/migration_templates/d7_block_content_type.yml
    @@ -1,16 +1,18 @@
    +  plugin: embedded_data
    

    Ditto.

  3. +++ b/core/modules/block_content/migration_templates/d7_custom_block.yml
    @@ -1,24 +1,27 @@
    -  id: bid
    +  id:
    +    plugin: dedupe_entity
    +    entity_type: block_content
    +    field: id
    +    length: 32
    

    Why dedupe in the D7 migration but not the D6 migration? Also, should field: id be bid instead?

  4. +++ b/core/modules/block_content/migration_templates/d7_custom_block.yml
    @@ -1,24 +1,27 @@
    -  no_stub: true
    

    Why would we suppress stubbing in D6 but allow it in D7?

Back to nw - the stubbing thing definitely looks wrong, and I'm awfully suspicious of the id/bid business.

mikeryan’s picture

Ah, it's not the field: id that's wrong, but it's missing source: bid, I think.

phenaproxima’s picture

Status: Needs work » Needs review
FileSize
16.36 KB
14.52 KB

I generalized the block_content_type and block_content_body_field migrations, which also required adding an update hook to block_content.

Why dedupe in the D7 migration but not the D6 migration? Also, should field: id be bid instead?

No reason, as far as I can tell. Changed it to a direct mapping.

Why would we suppress stubbing in D6 but allow it in D7?

I don't know -- probably a question best directed at @benjy -- but no_stub is rarely used so I can only assume it was done for a good reason. I have added it to the D7 migration.

Apologies for the length of the interdiff -- git seems to think that I rewrote entire files, instead of just moving a few things around.

Status: Needs review » Needs work

The last submitted patch, 14: 2415335-14.patch, failed testing.

The last submitted patch, 14: 2415335-14.patch, failed testing.

phenaproxima’s picture

Status: Needs work » Needs review
FileSize
16.03 KB

D'oh! Forgot to alter a couple of tests.

phenaproxima’s picture

Stupid git managed to leave a file out of the patch in #17.

The last submitted patch, 17: 2415335-17.patch, failed testing.

phenaproxima’s picture

On @gàbor-hojtsy's advice, changed the update hook to use the lower-level config API, rather than the entity system.

phenaproxima’s picture

Forgot to call save(TRUE) in the update hook.

The last submitted patch, 17: 2415335-17.patch, failed testing.

mikeryan’s picture

FileSize
15.74 KB

Interdiff since the last patch I reviewed - a lot's changed...

mikeryan’s picture

Status: Needs review » Reviewed & tested by the community

Here we go!

The last submitted patch, 1: migration_files_for-2415335-1.patch, failed testing.

The last submitted patch, 1: migration_files_for-2415335-1.patch, failed testing.

  • webchick committed 70d573c on 8.0.x
    Issue #2415335 by phenaproxima, miguelc303, quietone, mikeryan:...
webchick’s picture

Status: Reviewed & tested by the community » Fixed
FileSize
83.56 KB

Ok, reviewed this LIVE with Adam, Mike, and quietone. Works as advertised, once you manually place the block!

Look eetsa block!

WOOHOO!

Committed and pushed to 8.0.x. Thanks!

benjy’s picture

Works as advertised, once you manually place the block!

Can we not map the blocks into the correct regions, for the core themes?

webchick’s picture

Yes. My understanding is that's happening at #2408165: Migration Files for Drupal 7 Blocks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.