Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Create Files to enable end user to migrate Customs Blocks from Drupal 7 to Drupal 8.
Comment | File | Size | Author |
---|---|---|---|
#28 | Screen Shot 2015-09-14 at 1.01.36 PM.png | 83.56 KB | webchick |
#23 | interdiff.txt | 15.74 KB | mikeryan |
#21 | 2415335-21.patch | 17.04 KB | phenaproxima |
#20 | 2415335-20.patch | 17.03 KB | phenaproxima |
#18 | 2415335-18.patch | 17.15 KB | phenaproxima |
Comments
Comment #1
miguelc303 CreditAttribution: miguelc303 commentedI did a patch to enable end user to migrate Customs Blocks from Drupal 7 to Drupal 8.
Comment #2
benjy CreditAttribution: benjy at CodeDrop commentedComment #3
miguelc303 CreditAttribution: miguelc303 at Anexus commentedAdded organization support to Anexus IT
Comment #4
phenaproximaPostponing on #2384567: Migration Files for Drupal 7 Text Formats & Filters, since this migration depends on text formats and I'd prefer not to merge this patch into that issue.
Comment #5
phenaproximaComment #6
quietone CreditAttribution: quietone commentedmoved files to block_content module.
Comment #7
phenaproximaThis is unblocked now, since text format migration has landed.
Comment #8
phenaproximaChanging the project.
Comment #9
quietone CreditAttribution: quietone commentedComment #10
phenaproximaUpdated with a test, and merged in #2415325: Migration Files for Drupal 7 Block Content Type.
Comment #11
mikeryanNon-test diffs between D6 and D7.
Comment #12
mikeryanCan we justify changing the D6 migration to match here?
Ditto.
Why dedupe in the D7 migration but not the D6 migration? Also, should field: id be bid instead?
Why would we suppress stubbing in D6 but allow it in D7?
Back to nw - the stubbing thing definitely looks wrong, and I'm awfully suspicious of the id/bid business.
Comment #13
mikeryanAh, it's not the
field: id
that's wrong, but it's missingsource: bid
, I think.Comment #14
phenaproximaI generalized the block_content_type and block_content_body_field migrations, which also required adding an update hook to block_content.
No reason, as far as I can tell. Changed it to a direct mapping.
I don't know -- probably a question best directed at @benjy -- but no_stub is rarely used so I can only assume it was done for a good reason. I have added it to the D7 migration.
Apologies for the length of the interdiff -- git seems to think that I rewrote entire files, instead of just moving a few things around.
Comment #17
phenaproximaD'oh! Forgot to alter a couple of tests.
Comment #18
phenaproximaStupid git managed to leave a file out of the patch in #17.
Comment #20
phenaproximaOn @gàbor-hojtsy's advice, changed the update hook to use the lower-level config API, rather than the entity system.
Comment #21
phenaproximaForgot to call save(TRUE) in the update hook.
Comment #23
mikeryanInterdiff since the last patch I reviewed - a lot's changed...
Comment #24
mikeryanHere we go!
Comment #28
webchickOk, reviewed this LIVE with Adam, Mike, and quietone. Works as advertised, once you manually place the block!
WOOHOO!
Committed and pushed to 8.0.x. Thanks!
Comment #29
benjy CreditAttribution: benjy commentedCan we not map the blocks into the correct regions, for the core themes?
Comment #30
webchickYes. My understanding is that's happening at #2408165: Migration Files for Drupal 7 Blocks.