Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
See parent issue #2181257: [meta] Variables to config migration [d7] for instructions.
Comment | File | Size | Author |
---|---|---|---|
#13 | interdiff-2409447-10-13.txt | 4.36 KB | phenaproxima |
#13 | 2409447-13.patch | 5.19 KB | phenaproxima |
#11 | interdiff-2409447-7-10.txt | 3.2 KB | quietone |
#11 | 2409447-10.patch | 4.43 KB | quietone |
#7 | interdiff-2409447-6-7.txt | 2.14 KB | quietone |
Comments
Comment #1
hosef CreditAttribution: hosef commentedAttached is the YAML for this issue, from the patch in #2382117: Migration Files for Drupal 7 Variables.
Test(s) (and maybe a dump file) still need to be written.
Comment #2
miguelc303 CreditAttribution: miguelc303 at Anexus commentedAdded organization support to Anexus IT
Comment #3
jcost CreditAttribution: jcost commentedWill need to be submitted again to Core since moving from sandbox.
Comment #4
phenaproximaComment #5
phenaproximaComment #6
phenaproximaUpdated for HEAD, and wrote a test.
Comment #7
quietone CreditAttribution: quietone commentedreroll
Comment #8
quietone CreditAttribution: quietone commentedAnd moved to the search module.
Comment #9
phenaproximaThere is disparity between the D6 and D7 versions of this migration; the D6 one selects several variables which are never mentioned in the process pipeline. That's a WTF and should be addressed before this gets committed.
Comment #10
quietone CreditAttribution: quietone commentedThe differences your've spotted are nicely outlined in the know issues documentation, specifically
Search Settings. According to that D7 contains 2 variables, search_tag_weights and search_and_or_limit, that are not in D6 or D8.
However, looking at D8 search settings it seems that 'search_and_or_limit' is now 'and_or_limit' and 'search_tag_weights' is now 'tag_weights'.
Since this issue is clearly marked D7, I'll make a new issue for the change to d6_search_settings.yml.
Comment #11
quietone CreditAttribution: quietone commentedAdded migration for 'search_and_or_limit' and 'search_tag_weights' and tests.
Comment #12
mikeryanI do think it's helpful for long-term maintenance to keep the D6 and D7 tests as in-sync as possible - the only differences should really be inherent differences between D6 and D7.
The module dependencies are unnecessary and should be removed.
Discrepancy from D6, where this is called MigrateSearchConfigsTest.
Why is installConfig necessary here but not in the D6 test?
Discrepancy with D6, where this is testSearchSettings().
Can use $this->config here (see the D6 test).
Comment #13
phenaproximaAll fixed.
Comment #14
mikeryanComment #16
webchickCommitted and pushed to 8.0.x. Thanks!