Problem/Motivation

The "RSS publishing" settings form allowed users to change basic RSS feed behaviours on Drupal prior to version 8. Drupal 8/9 now uses a view to provide the front page /rss.xml feed link. This view does not use the RSS form settings, which is confusing for users.

Proposed resolution

Remove the feed description and number of items settings from admin/config/services/rss-publishing form, as neither of these actually have any effect anywhere.

The feed content setting may still be used by Views, this is more complicated to unwind and will be removed in #2601030: Views RSS view mode settings are completely broken.

Remaining tasks

None

User interface changes

The feed description and number of items settings are removed.

API changes

None

Original report by @cafuego

CommentFileSizeAuthor
#94 2409413#comment-13910940.patch538 bytesalex.mazaltov
#87 RSSpublishingSettingsForm-2409413-87.patch9.02 KBSivaprasadC
#80 RSS-Feed-Review-2.PNG16.83 KBSivaprasadC
#80 RSS-Feed-Review-1.PNG43.73 KBSivaprasadC
#77 interdiff.2409413.75-77.txt645 byteslongwave
#77 2409413-77.patch9.03 KBlongwave
#75 interdiff.2409413.73-75.txt849 byteslongwave
#75 2409413-75.patch9.06 KBlongwave
#73 interdiff.2409413.70-73.txt2.74 KBlongwave
#73 2409413-73.patch8.23 KBlongwave
#70 2409413-70.patch5.81 KBayushmishra206
#60 2409413-56-59-interdiff.txt7.64 KBlokapujya
#60 2409413-59.patch8.22 KBlokapujya
#58 2409413-56-interdiff.txt7.64 KBlokapujya
#58 2409413-56.patch14.1 KBlokapujya
#56 2409413-56-interdiff.txt2.86 KBlokapujya
#56 2409413-56.patch14.1 KBlokapujya
#51 interdiff.txt1.71 KBsnehi
#51 Drupal_Core-Corrected_the_patch-2409413-51.patch13.63 KBsnehi
#47 Drupal_Core-Corrected_the_patch-2409413-47.patch14.6 KBvipul.patil7888
#43 remove_fields_that_do-2409413-44.patch9.12 KBalvar0hurtad0
#42 remove_fields_that_do-2409413-42.patch9.25 KBalvar0hurtad0
#32 2409413-2-32.patch9.24 KBalexpott
#32 29-32-interdiff.txt1.7 KBalexpott
#29 2409413-2-29.patch7.54 KBalexpott
#20 2409413-rss-settings-20.patch7.16 KBcafuego
#20 2409413-rss-settings-20.patch7.16 KBcafuego
#16 2409413-rss-settings-16.patch13.31 KBcafuego
#10 2409413-rss-settings-10.patch12.13 KBcafuego
#7 2409413-rss-settings-7.patch12.11 KBcafuego
#3 2409413-rss-settings-3.patch8.91 KBcafuego
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

cafuego’s picture

Issue summary: View changes
cafuego’s picture

Issue summary: View changes
cafuego’s picture

Status: Active » Needs review
FileSize
8.91 KB

Attached patch removes the RSS publishing settings form, its variables and its tests, the menu links, the RSS publishing migrations.

mradcliffe’s picture

+++ b/core/modules/config_translation/src/Tests/ConfigTranslationListUiTest.php
index 36b3bff..0000000
--- a/core/modules/migrate_drupal/config/install/migrate.migration.d6_system_rss.yml

Does this need to change to a view migration?

cafuego’s picture

I don't know, what's a view migration? ;-)

Status: Needs review » Needs work

The last submitted patch, 3: 2409413-rss-settings-3.patch, failed testing.

cafuego’s picture

Status: Needs work » Needs review
FileSize
12.11 KB

Removed superfluous (pending decision on whether a view migration is needed) test.

Status: Needs review » Needs work

The last submitted patch, 7: 2409413-rss-settings-7.patch, failed testing.

cafuego’s picture

Status: Needs work » Needs review
FileSize
12.13 KB

Make patch apply.

jibran’s picture

This is RTBC IMO but do we need a change record for that.? We should ping some form migration team to eyeball that patch.

dawehner’s picture

Should we migrate those settings to the appropriate views settings or just drop it entirely as the patch does?

cafuego’s picture

I'm happy either way, but I have no idea how to migrate anything to a views setting :-/

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Theoretically we could but I doubt anyone cares about those settings anyway, especially because it was also used for taxonomy/term/.../feed afaik

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 10: 2409413-rss-settings-10.patch, failed testing.

cafuego’s picture

Status: Needs work » Needs review
FileSize
13.31 KB

Updated the patch, should apply again and hopefully pass testing.

jibran’s picture

Status: Needs review » Reviewed & tested by the community

Here we go again.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 16: 2409413-rss-settings-16.patch, failed testing.

The last submitted patch, 16: 2409413-rss-settings-16.patch, failed testing.

cafuego’s picture

Removed the exceptioning test, restored the generated Table files, so they don't mismatch on checksum.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Well yeah to be fair we should not manipulate the data coming from D6. We can't really deny the existence of it.

xjm’s picture

Priority: Normal » Major
Status: Reviewed & tested by the community » Needs work
Issue tags: +rc target

Nice, I just noticed today that this form still existed in #2578995: Update the link descriptions on the Configuration page for the system module.

I think we need an upgrade path here to delete the stale system.rss config, though.

Also, a UI that does nothing is a WTF and it doesn't break anything to remove a thing that does nothing, so tagging this as an RC target.

xjm’s picture

xjm’s picture

I guess maybe this should also have a followup for migrating the settings to the View config, but Views migration is still under development.

catch’s picture

Title: "RSS publishing" settings form can be removed » Remove the "RSS publishing" settings form because it does nothing

Just re-titling because it sounded like a bug that it could be removed, not a feature ;)

alexpott’s picture

I'm not sure that this issue is correct. This form also configures the view mode used by Drupal\node\Plugin\views\row\Rss. In order to remove system.rss completely we need to store the view mode with each view. In fact there is code hard coded to the fake rss display modes...

    if ($view_mode != 'title') {
      // We render comment contents.
      $description_build = $build;
    }
alexpott’s picture

This is super complex because the form is configuring a kind of default view mode (it is not a real entity view mode)... system.rss:item.view_mode.

This is used when a view sets the view mode to 'default'... see the code in Drupal\node\Plugin\views\row\Rss

    $display_mode = $this->options['view_mode'];
    if ($display_mode == 'default') {
      $display_mode = \Drupal::config('system.rss')->get('items.view_mode');
    }

Later on it does

    if ($display_mode != 'title') {
      // We render node contents.
      $description_build = $build;
    }

Which is totally weird.

There is very similar code in Drupal\comment\Plugin\views\row\Rss

I think we have two options here:

  1. Just remove the feed_default_items field and feed_description from the form and system.rss:item.limit and system.rss:channel.description because they have no effect. The form will look super weird but we don't have to disentangle the mess that is items.view_mode.
  2. Try to remove the lot.
alexpott’s picture

Also should mention that I discussed with the other committers and we all agreed that at least removing the parts that can never have any effect are "rc target" as a useless UI is very confusing.

alexpott’s picture

Status: Needs work » Needs review
FileSize
7.54 KB

So here is a patch doing option 1. There is no interdiff because it is a different approach from the previous patches.

If we do option 2 I have no idea about the upgrade path. 'title' is a special view mode hacked into the plugins. The default view mode 'rss' is provided by core but once you change the form you can never re-select. The teaser view mode might exist. The fulltext view mode almost certainly does not. I think we should fix all the view mode wonky-ness in another patch as it is likely to be hard. Basically, the whole view mode setting is currently very broken :(

    $form['feed_view_mode'] = array(
      '#type' => 'select',
      '#title' => t('Feed content'),
      '#default_value' => $this->config('system.rss')->get('items.view_mode'),
      '#options' => array(
        'title' => t('Titles only'),
        'teaser' => t('Titles plus teaser'),
        'fulltext' => t('Full text'),
      ),
      '#description' => t('Global setting for the default display of content items in each feed.')
    );

And the default value is RSS :(

alexpott’s picture

Title: Remove the "RSS publishing" settings form because it does nothing » Remove fields that do nothing from the "RSS publishing" settings form

Opened #2601030: Views RSS view mode settings are completely broken to address the way more complex items.view_mode

Status: Needs review » Needs work

The last submitted patch, 29: 2409413-2-29.patch, failed testing.

alexpott’s picture

Status: Needs work » Needs review
Issue tags: -Needs upgrade path, -Needs upgrade path tests
FileSize
1.7 KB
9.24 KB

Nothing is translatable on the form anymore and this is not the only config that is tested for translatability.

catch’s picture

Version: 8.0.x-dev » 8.1.x-dev
Issue tags: -rc target

Moving to 8.1.x since the form structure changes non-trivially + upgrade path + not sure what happens if an install profile overrides invalid keys.

dawehner’s picture

Status: Needs review » Needs work
+++ b/core/modules/system/system.install
@@ -1847,3 +1847,22 @@ function system_update_8013() {
+/**
+ * @addtogroup updates-8.0.0-rc
+ * @{
+ */
+
+/*
+ * Remove meaningless configuration from system.rss
+ */
+function system_update_8014() {
+  \Drupal::configFactory()->getEditable('system.rss')
+    ->clear('channel')
+    ->clear('items.limit')
+    ->save();
+}
+
+/**
+ * @} End of "addtogroup updates-8.0.0-rc".
+ */

We should now put some docblock beyond RC

catch’s picture

And the update number should be 8100.

dawehner’s picture

Component: base system » system.module
Issue tags: +Novice

Let's add a Novice task for that.

snehi’s picture

Assigned: Unassigned » snehi
snehi’s picture

@dawehner Can you please explain what do you mean by

We should now put some docblock beyond RC

catch’s picture

That's for the update defgroup.

snehi’s picture

Issue tags: +Needs reroll

It needs reroll tagging to it.

snehi’s picture

Assigned: snehi » Unassigned
alvar0hurtad0’s picture

Status: Needs work » Needs review
FileSize
9.25 KB

here's the reroll

alvar0hurtad0’s picture

:S.... sorry, here's the reroll.

The last submitted patch, 42: remove_fields_that_do-2409413-42.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 43: remove_fields_that_do-2409413-44.patch, failed testing.

vipul.patil7888’s picture

Assigned: Unassigned » vipul.patil7888
vipul.patil7888’s picture

Hi,

PFA of patch that will get apply successfully.

Thanks,
Vipul

vipul.patil7888’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 47: Drupal_Core-Corrected_the_patch-2409413-47.patch, failed testing.

snehi’s picture

  1. +++ b/core/modules/config_translation/src/Tests/ConfigTranslationUiTest.php
    @@ -74,6 +74,9 @@ class ConfigTranslationUiTest extends WebTestBase {
    +  /**
    +   *
    +   */
    

    Why so ?

  2. +++ b/core/modules/config_translation/src/Tests/ConfigTranslationUiTest.php
    @@ -617,7 +620,7 @@ public function testPluralConfigStringsSourceElements() {
    +      // Import a .po file to add a new language with a given number of plural forms.
    

    80 col ?

  3. +++ b/core/modules/config_translation/src/Tests/ConfigTranslationUiTest.php
    @@ -770,7 +773,7 @@ public function testLocaleDBStorage() {
    +    // Revert custom translations to base translation.
    

    base translations ?

  4. +++ b/core/modules/config_translation/src/Tests/ConfigTranslationUiTest.php
    @@ -840,7 +838,7 @@ public function testSequenceTranslation() {
    +      'elephant',
    

    Is this necessary ?

  5. +++ b/core/modules/system/system.install
    @@ -1866,6 +1866,15 @@ function system_update_8014() {
    + * Remove meaningless configuration from system.rss
    

    Must End with .

snehi’s picture

Status: Needs work » Needs review
FileSize
13.63 KB
1.71 KB

How is it ?

Status: Needs review » Needs work

The last submitted patch, 51: Drupal_Core-Corrected_the_patch-2409413-51.patch, failed testing.

mradcliffe’s picture

Issue summary: View changes

Good work so far. I have reviewed the latest patch, #51, with the following notes:

  1. +++ b/core/modules/config_translation/src/Tests/ConfigTranslationListUiTest.php
    @@ -48,6 +49,9 @@ class ConfigTranslationListUiTest extends WebTestBase {
    +  /**
    +   *
    +   */
    
    +++ b/core/modules/config_translation/src/Tests/ConfigTranslationUiTest.php
    @@ -74,6 +74,9 @@ class ConfigTranslationUiTest extends WebTestBase {
    +  /**
    +   *
    +   */
    
    +++ b/core/modules/config_translation/tests/src/Unit/ConfigNamesMapperTest.php
    @@ -88,6 +88,9 @@ class ConfigNamesMapperTest extends UnitTestCase {
    +  /**
    +   *
    +   */
    

    Like @snehi mentioned, these docblocks should contain @inheritdoc

  2. +++ b/core/modules/system/system.install
    @@ -1866,6 +1866,15 @@ function system_update_8014() {
       }
    +
    ...
     }
    

    This is missing a trailing left brace causing the PHP syntax error, which causes the test bot to fail.

  3. +++ b/core/modules/system/system.install
    @@ -1866,6 +1866,15 @@ function system_update_8014() {
    +/*
    + * Remove meaningless configuration from system.rss.
    + */
    

    This should be updated per @dawhener in comment #34.

    What this means is that the dockblock ending at the bottom of the file should be moved above this update and changed to 8.0.0. Then, a new @addtogroup dock block added before and below this update function as 8.1.0.

  4. +++ b/core/modules/system/system.install
    @@ -1866,6 +1866,15 @@ function system_update_8014() {
    +function system_update_8015() {
    

    Still needs to be changed per @catch in #35.

Fred Martin’s picture

Issue tags: -Needs reroll

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

lokapujya’s picture

Status: Needs work » Needs review
Issue tags: -Novice
FileSize
14.1 KB
2.86 KB

Fixed items in #53 (and rerolled for 8.2. )

xjm’s picture

Status: Needs review » Needs work

Thanks @lokapujya.

#56 has a number of out-of-scope coding standards fixes, so marking NW for that.

lokapujya’s picture

Assigned: vipul.patil7888 » Unassigned
Status: Needs work » Needs review
FileSize
14.1 KB
7.64 KB

Maybe we still want those changes in a separate issue.

Status: Needs review » Needs work

The last submitted patch, 58: 2409413-56.patch, failed testing.

lokapujya’s picture

Status: Needs work » Needs review
FileSize
8.22 KB
7.64 KB

Redo.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

longwave’s picture

Status: Needs review » Needs work
Issue tags: +Needs reroll

Reviving this as I just noticed the mostly-useless RSS settings form under Web Services and then found #3019793: channel.description is ignored before this issue.

NW as the patch no longer applies, but shouldn't be too hard to reroll.

ayushmishra206’s picture

Rerolled the patch for 9.1.x. Please review, Thanks.

ayushmishra206’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 70: 2409413-70.patch, failed testing. View results

longwave’s picture

Fixed test failures due to parts of #60 being moved around in the codebase over time.

Status: Needs review » Needs work

The last submitted patch, 73: 2409413-73.patch, failed testing. View results

longwave’s picture

Status: Needs work » Needs review
FileSize
9.06 KB
849 bytes

Missed one.

Status: Needs review » Needs work

The last submitted patch, 75: 2409413-75.patch, failed testing. View results

longwave’s picture

Status: Needs work » Needs review
FileSize
9.03 KB
645 bytes

Copy/paste error.

quietone’s picture

This issue summary is out of date, let's get that updated.

SivaprasadC’s picture

Assigned: Unassigned » SivaprasadC
SivaprasadC’s picture

Assigned: SivaprasadC » Unassigned
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
FileSize
43.73 KB
16.83 KB

Hi,

The patch looks good to me. It applied cleanly to 9.1.x branch. Please find the attached.

+1 RTBC

longwave’s picture

Issue summary: View changes
Issue tags: -Needs issue summary update

Thanks for reviewing. Updated IS.

alexpott’s picture

Status: Reviewed & tested by the community » Needs work

http://codcontrib.hank.vps-private.net/search?text=items.limit&filename= - something is using one of bits of config. At the very least we need an issue created against the module to stop using this... https://www.drupal.org/project/monster_menus - for what it is worth the 8.x-1.x branch has had quite a few recent commits.

The other removals look fine - http://codcontrib.hank.vps-private.net/search?text=system.rss&filename=

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

longwave’s picture

Status: Needs work » Reviewed & tested by the community
catch’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

The monster menus issue is now fixed.

Needs a re-roll, to me this looks fine to land in 9.2.x- there's a tiny chance that some custom code somewhere is doing what monster menus did, but seems very low risk and it's a real bug having these phantom settings in the UI.

SivaprasadC’s picture

Assigned: Unassigned » SivaprasadC
SivaprasadC’s picture

Assigned: SivaprasadC » Unassigned
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
9.02 KB

Hi @catch,

Based on your suggestion, rerolled the patch. PFA.

longwave’s picture

Status: Needs review » Reviewed & tested by the community

Reroll looks good.

  • catch committed cf4a609 on 9.2.x
    Issue #2409413 by cafuego, longwave, lokapujya, alexpott, alvar0hurtad0...
catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed cf4a609 and pushed to 9.2.x. Thanks!

longwave’s picture

Just noticed that following this the "RSS publishing" description is now wrong:

Configure the site description, the number of items per feed, and whether feeds should be titles/teasers/full-text.

The first two options no longer exist. Unsure if we need a followup or should just remove this entirely in #2601030: Views RSS view mode settings are completely broken

alex.mazaltov’s picture

Need to add @see tag in block comment above function system_post_update_delete_rss_settings()

alex.mazaltov’s picture

Status: Fixed » Needs review
alex.mazaltov’s picture

Please review and commit

penyaskito’s picture

The landing of this issue on 9.2.x broke my tests on Lingotek module: #3187658: Fix tests depending on system.rss config object as they are failing on 9.2.x

I could just pick any other config object for the purpose of those tests, so don't really matters to me, but wondering if this could affect other modules in different ways, as that wasn't detected on http://codcontrib.hank.vps-private.net search.

I wouldn't expect those to be removed in a minor version anyway, even if unused on core. That's breaking BC.

longwave’s picture

So we have a deprecation policy for config schema (which we broke here, by just removing the schema):

https://www.drupal.org/about/core/policies/core-change-policies/drupal-c...

However, I couldn't find a policy for config entities - but I guess as they have to follow the schema, we should put back the values even if they aren't used, and then only delete them in D10?

longwave’s picture

I looked back to see if we had done anything similar and found #3022401: Remove useless config action.settings.recursion_limit

There we also deleted both the config and schema, without deprecations. @alexpott stated in #37

Discussed with @catch. This issue needs a change record.

@catch felt that config is along the lines of schema or data structure. Meaning he think's we can remove it with a change record. There's bound to be cases where that's harder because people actually check the value directly, but as a general rule.

Not saying this is the right thing to do, but we do have precedent for making these sorts of changes in a minor release. However we also didn't follow our own config schema deprecation policy then, either.

catch’s picture

So config schema deprecation was introduced for #2829919: Either avoid or explicitly test binary encoding in default configuration (which isn't closed yet, but does have a patch using it). In that case it's used to replace one config key with another.

In the case of this form, we're not changing the structure to a different one, but removing keys that are redundant, so I don't think it's necessary to deprecate first.

However we should probably update the policy to make it clearer what deprecation should be used for.

If we had deprecated then it wouldn't have broken the lingotek module, but that was a test-only breakage (similar to if lingotek was relying to the structure of the RSS settings form itself). I'd feel differently if runtime code broke, but I think it's OK to close this again.

effulgentsia’s picture

Issue tags: +9.2.0 release notes

In case other modules run into what #95 ran into, let's mention this in the release notes.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

penyaskito’s picture

I changed my mind and I agree with @catch here in this particular use case. Is quite probable than I would have missed the deprecation warning (if using @legacy, which I don't remember for this particular test) in tests until they actually fail. If I were not using @legacy, the deprecation will break them anyway.

So in the case they are removed and not replaced, breaking builds so people notice ASAP seems like the right thing to do.

mitthukumawat’s picture

The feed description and number of items from RSS Publishing setting page seems removed in drupal 9.3.x-dev version. But it still exists in drupal 9.1.
Patch #87 applied cleanly and resolved this.

effulgentsia’s picture

But it still exists in drupal 9.1.

Correct. In order to not disrupt existing sites, this will not get committed to Drupal 9.1. Site owners who are comfortable with adding core patches to their sites are welcome to use #87 until they upgrade to Drupal 9.2.

longwave’s picture

Status: Needs review » Fixed

Nothing left to do here.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.