Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
In core/modules/views_ui/src/ViewUI.php
there are several lines like this:
array('data' => array('#type' => 'inline_template', '#template' => "<strong>{% trans 'Query' %}</strong>")),
However, elsewhere in core, each of #something elements is on a separate line, like this one from core/modules/system/tests/modules/theme_test/src/ThemeTestController.php
:
$element['test'] = array(
'#type' => 'inline_template',
'#template' => 'test-with-context {{ llama }}',
'#context' => array('llama' => 'muuh'),
);
Your mission, should you choose to accept it, is to re-format these lines so they match our lovely Coding Standards!
Comment | File | Size | Author |
---|---|---|---|
#6 | fix-whitespaces-of-inline-template-2409391-6.patch | 4.1 KB | gbisht |
#2 | fix-whitespaces-of-inline-template-2409391-2.patch | 4.08 KB | Cogax |
Comments
Comment #1
Cogax CreditAttribution: Cogax commentedComment #2
Cogax CreditAttribution: Cogax commentedI've made some changes. Hope it fits.
Comment #3
Cogax CreditAttribution: Cogax commentedComment #4
karengrey CreditAttribution: karengrey commentedCode is now re-formatted and meets coding standards.
Good job!
Comment #5
gvsoWe should include comma at the end of every array item
Something like this
Comment #6
gbisht CreditAttribution: gbisht commentedFormatting done!
Comment #7
mglamanPatch applies clean, #6 addressed remaining lack of comma usage.
Comment #8
gvsoRTBC +1 for #6
Comment #11
gvsoWondering why it failed. Marking it as RTBC again!
Comment #14
gvsoWhy it failed again? It's weird. Marking as RTBC one more time :)
Comment #15
alexpottCommitted 610e90e and pushed to 8.0.x. Thanks!