CommentFileSizeAuthor
#4 drupal8-remove-views_get_applicable_views-2405367-4.patch1.01 KBashutoshsngh
#1 drupal8-remove-views_get_applicable_views-2405367-1.patch1.8 KBashutoshsngh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ashutoshsngh’s picture

ashutoshsngh CreditAttribution: ashutoshsngh commented
Assigned: ashutoshsngh » Unassigned
Status: Needs work » Needs review
FileSize
drupal8-remove-views_get_applicable_views-2405367-1.patch1.8 KB
yogen.prasad’s picture

yogen.prasad CreditAttribution: yogen.prasad commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Needs work 
+++ b/core/modules/taxonomy/src/Entity/Term.php
@@ -64,7 +64,7 @@ public static function postDelete(EntityStorageInterface $storage, array $entiti
-      if ($children = taxonomy_term_load_children($tid)) {
+      if ($children = \Drupal::entityManager()->getStorage('taxonomy_term')->loadChildren($tid)) {

Out of scope change.

ashutoshsngh’s picture

ashutoshsngh CreditAttribution: ashutoshsngh commented
Issue tags: -Novice. @deprecated #dcddelhi +Novice. @deprecated #dcdelhi
FileSize
drupal8-remove-views_get_applicable_views-2405367-4.patch1.01 KB

Fixed

ashutoshsngh’s picture

ashutoshsngh CreditAttribution: ashutoshsngh commented
Status: Needs work » Needs review
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

Alright

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Title: Remove views_get_applicable_views() » [Change record] Remove views_get_applicable_views()
Project: Drupal core » Views (for Drupal 7)
Version: 8.0.x-dev » 8.x-3.x-dev
Component: views.module » Code
Category: Task » Bug report
Status: Reviewed & tested by the community » Active
Issue tags: +Needs change record

Used code is a bug. Committed b8dee6c and pushed to 8.0.x. Thanks!

Moved to the views issue queue for a change record.

YesCT’s picture

YesCT CreditAttribution: YesCT commented
Issue tags: -Novice. @deprecated #dcdelhi +Novice, +@deprecated, +#dcdelhi

@ashutoshsngh
Thank you for working on this issue.

Tags are separated with a comma, not a space.

Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews as a volunteer and at City of Oaks Design commented
Project: Views (for Drupal 7) » Drupal core
Version: 8.x-3.x-dev » 8.7.x-dev
Component: Code » views.module

For more information as to why this issue was moved to the Drupal core project, please see issue #3030347: Plan to clean process issue queue

Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews as a volunteer and at City of Oaks Design commented
Project: Drupal core » Views (for Drupal 7)
Version: 8.7.x-dev » 7.x-3.x-dev
Component: views.module » Code
Status: Active » Closed (outdated)

Moving back to the contributed Views issue queue and closing as outdated per https://www.drupal.org/project/views/issues/3030347#comment-13023447