Problem/Motivation

Temporary files are now handled by the EntityFile destination but this errors out when both the source and the destination are the exact same path which is possible when sites use the operating system /tmp path.

Proposed resolution

Handle this situation in the destination.

Remaining tasks

Write patch, update tests.

User interface changes

n/a

API changes

n/a

CommentFileSizeAuthor
#1 2405337-1-FAIL.patch710 bytesbenjy
#1 2405337-1.patch1.61 KBbenjy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

benjy’s picture

benjy CreditAttribution: benjy commented
Status: Active » Needs review
FileSize
2405337-1.patch1.61 KB
2405337-1-FAIL.patch710 bytes

Patch and tests attached. The EntityFile destination still has another issue with handling temporary files when the path is not absolute, will create a separate issue for that.

Status: Needs review » Needs work

The last submitted patch, 1: 2405337-1-FAIL.patch, failed testing.

benjy’s picture

benjy CreditAttribution: benjy commented
Status: Needs work » Needs review
ultimike’s picture

ultimike
Primary language English
Location Florida, USA
CreditAttribution: ultimike commented
Status: Needs review » Reviewed & tested by the community

Patch and test make perfect sense.

-mike

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Migrate is not subject to the beta evaluation. Committed 3f1c3c0 and pushed to 8.0.x. Thanks!

  • alexpott committed 3f1c3c0 on 8.0.x 
    Issue #2405337 by benjy: EntityFile destination doesn't handle temporary...
mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan commented

This change introduced #2414365: File migration fails when the files are at a remote URI.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.