Whilst investigating how Drupal core themes use typography I notices that the Seven theme has an admin-options component that appears to be completely unused. I've not been able to find it in Drupal 6 or Drupal 7 (but that has the same styles). Perhaps I'm missing something but maintaining dead css wastes time.

CommentFileSizeAuthor
#1 2405213.1.patch1.41 KBalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Active » Needs review
FileSize
2405213.1.patch1.41 KB
LewisNyman’s picture

LewisNyman
he/him
CreditAttribution: LewisNyman commented
Issue tags: +frontend, +CSS
Parent issue: » #2405553: Ensure Seven's code is inline with the current standards
LewisNyman’s picture

LewisNyman
he/him
CreditAttribution: LewisNyman commented
Status: Needs review » Reviewed & tested by the community

I traced this code back to the initial Seven commit in #484860: Initial D7UX admin theme. From #10:

Here is an updated patch, the images from above are still current. This patch is a combination of yhahn's "slate" theme and Gábor Hojtsy's "overlay" theme, and retains the name "slate".

I wonder how much CSS has been copied over that isn't used... I guess we will find out in #2405553: Ensure Seven's code is inline with the current standards

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

  • catch committed 77f8213 on 8.0.x 
    Issue #2405213 by alexpott: Remove admin-options component from Seven...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.