Title says it all.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
CommentFileSizeAuthor
#3 static-in-renderer-2404831-3.patch3.89 KBzealfire
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Issue tags: +Novice, +php-novice
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

Thank you for creating the issue!

zealfire’s picture

zealfire CreditAttribution: zealfire commented
Assigned: Unassigned » zealfire
Status: Active » Needs review
FileSize
static-in-renderer-2404831-3.patch3.89 KB

Hopefully i have included all the changes required.Please review.
Thanks

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

No self:: call is left.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Category: Task » Bug report
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Not using late static binding here is a bug. This issue is a minor bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes.

Committed 29c50df and pushed to 8.0.x. Thanks!

  • alexpott committed 29c50df on 8.0.x 
    Issue #2404831 by zealfire: self::$stack -> static::$stack in Renderer

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.