Add an empty text on "Add Custom Block" page when no custom block types are available

The problem is that you don't have any custom block types configured by default, see admin/structure/block/block-content/types

Afaik we should, similarily to the node types page (node/add) tell the user in case there are none defined.

@sachbearbeiter
Well I think you could provide such a fix for the block/add page ... having some short help text there is useful, no question.

Here is a patch to add the text to the twig file. I'll open an issue to have this added to seven as well.

Please do it here too, no need for two issues

Hi, the fix belongs in the controller, themes should need to worry about this kind of logic.
New patch, no interdiff - new approach.

some things berdir pointed out

1. +++ b/core/modules/block_content/src/Tests/BlockContentTestBase.php
   @@ -98,4 +105,13 @@ protected function createBlockContentType($label) {
   +  protected function createInitialBlockType() {
   

   Instead of initial, I'm wondering if "default" or "basic" (because that is how the block type is named) would be a better name.

   Also, note that drupalCreateContentType() creates the body field by default, wondering if we'd want that here as well, then we would not even need the helper method?

2. +++ b/core/modules/block_content/src/Tests/BlockContentTestBase.php
   @@ -98,4 +105,13 @@ protected function createBlockContentType($label) {
   +    // Ensure the basic bundle exists. This is provided by the standard profile.
   

   As discussed, the standard profile reference seems not helpful to me, I don't know what that is trying to say me.

3. +++ b/core/modules/block_content/src/Tests/BlockContentTypeTest.php
   @@ -33,18 +33,31 @@ class BlockContentTypeTest extends BlockContentTestBase {
   +    $this->assertText('You have not created any block types yet');
   

   I'm not sure anymore when we should use t() exactly and when not. Usually, I think we still use it when testing strings that were passed through t(), but it doesn't really matter as it's not the same string anyway.

Fixes #13

reroll

Not sure what I'm doing wrong here

neclimdul+1000

doh

doh^2

Thanks @larowlan, I did a manual test to confirm the message is displayed when no custom block types are available.

I have split the patch with a tests-only edition; the patch file has no changes compared to #25.

Annotated screenshot to show the new behavior:

I updated the issue summary to reflect the changes in the patch and included a beta evaluation.

Committed 834c5a2 and pushed to 8.0.x. Thanks!

Thank you for adding the beta evaluation to the issue summary.