Problem/Motivation

For a while settings.php contained debug settings for Twig, but they were moved to services.yml in #2251113: Use container parameters instead of settings. Also see the the change record: https://www.drupal.org/node/2317817

This change was not updated in the $settings docblock of settings.php however, leaving me searching for a while :(

The culprit:

/**
 * Settings:
 *
 * $settings contains environment-specific configuration, such as the files
 * directory and reverse proxy address, and temporary configuration, such as
 * turning on Twig debugging and security overrides.
 *
 * @see \Drupal\Core\Site\Settings::get()
 */

Proposed resolution

Remove the text from default.settings.php that says the file contains Twig debug settings.

Remaining tasks

  • Write a patch
  • Review

User interface changes

None

API changes

None

CommentFileSizeAuthor
#2 2401253-2.patch506 bytesidebr
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

idebr’s picture

idebr CreditAttribution: idebr commented
Status: Active » Needs review
Related issues: +#2322539: Improve (and shorten) documentation in default.services.yml

Attached patch changes the text to read:

/**
 * Settings:
 *
 * $settings contains environment-specific configuration, such as the files
 * directory and reverse proxy address, and temporary configuration, such as
 * security overrides.
 *
 * @see \Drupal\Core\Site\Settings::get()
 */
idebr’s picture

idebr CreditAttribution: idebr commented
FileSize
2401253-2.patch506 bytes
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quickfix

+1

  • jhodgdon committed 425a41e on 8.0.x 
    Issue #2401253 by idebr: settings.php says it contains Twig debug...
jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Reviewed & tested by the community » Fixed

Thanks! Committed to 8.0.x.

Beta note: Docs only, Ok to commit.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.