Token API will match tokens with empty types or tokens, e.g. [:invalid]

Problem/Motivation

The Token API uses this regex to match and assemble a list of tokens in a string:

   // Matches tokens with the following pattern: [$type:$name]
    // $type and $name may not contain [ ] characters.
    // $type may not contain : or whitespace characters, but $name may.
    preg_match_all('/
      \[             # [ - pattern start
      ([^\s\[\]:]*)  # match $type not containing whitespace : [ or ]
      :              # : - separator
      ([^\[\]]*)     # match $name not containing [ or ]
      \]             # ] - pattern end
      /x', $text, $matches);

It uses the * character which will match zero or more characters, meaning it will match empty token types or tokens, which could lead to unexpected results.

Beta phase evaluation

Proposed resolution

Use the + repetition character (1 or more) rather than * (0 or more).

Remaining tasks

User interface changes

None.

API changes

None.