Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
When i edit a view i found an issue in exposed filter. UI of exposed filter is breaking. Adding screenshot of the issue.
Proposed resolution
Apply the exposed form css that comes with the Views module to the Views UI preview form.
Remaining tasks
Write a patchAdd screenshots- Review
API changes
None
Beta phase evaluation
| Issue category | Bug because the issue reports a visual regression in a single component |
|---|---|
| Issue priority | Normal because the regression does not affect the functionality of the component |
| Unfrozen changes | Unfrozen because it only changes css |
| Prioritized changes | This is a prioritized issue because it is a bugfix |
| Disruption | Not disruptive |
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | interdiff-10-3.txt | 606 bytes | idebr |
| #10 | views_ui-exposed-filters-preview-2396465-10.patch | 2.05 KB | idebr |
| #10 | 2333719-10-after-rtl.png | 257.69 KB | idebr |
| #10 | 2333719-10-after.png | 244.82 KB | idebr |
| #10 | 2333719-10-before.png | 251.57 KB | idebr |
Comments
Comment #1
Vidushi Mehta CreditAttribution: Vidushi Mehta commentedComment #2
moonpeak CreditAttribution: moonpeak commentedYes, this is an issue visible on drupal 8 core. Views Exposed filters UI is breaking.
Comment #3
idebr CreditAttribution: idebr commentedI applied the css that comes with views/views.exposed_form to the Views UI preview. For the css to apply correctly, i had to make some selectors for the arguments textfield more strict.
Screenshot after:
Comment #4
jibranCan we have RTL screenshot?
Comment #5
idebr CreditAttribution: idebr commentedScreenshot after (rtl):
Comment #6
jibranThanks
Comment #7
Vidushi Mehta CreditAttribution: Vidushi Mehta commentedI have reviewed the #3 patch.And its resolving the Exposed Filter issue.
Comment #9
LewisNymanIn #2333719: Abstract Views Exposed Form styling out into a reusable class We are making the exposed filter CSS reusable so it can be reapplied to multiple situations. If we postpone this issue until that one is commited then all we would need to do is add that class to the preview form. How does that sound?
Comment #10
idebr CreditAttribution: idebr commented@LewisNyman This patch fixes a current regression in the Views UI so I'd prefer it take priority over a task to make css in the Views UI more abstract.
The only overlap from this patch with #2333719: Abstract Views Exposed Form styling out into a reusable class is addition of the views.exposed-form library, you could leave the removal of the library for a followup and postpone the followup on this issue?
I have rerolled the patch against the latest
HEAD.Screenshot before:
Screenshot after:
Screenshot after (rtl):
Comment #11
LewisNyman@idebr Sounds good to me. I'll review this when I have more time this week unless someone beats me to it.
Comment #12
idebr CreditAttribution: idebr commentedI believe this can go back to RTBC per #6 and #7 and the last change was a reroll, but please correct me if I am wrong.
Comment #13
idebr CreditAttribution: idebr commentedAdded a beta evaluation.
Comment #14
alexpottCommitted b54a2c9 and pushed to 8.0.x. Thanks!
Thanks for adding the beta evaluation to the summary.