Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug
Unfrozen changes Unfrozen because it only changes markup.
Prioritized changes This falls under "usability and user experience improvements" in that the Add another item button is nowhere near the items it would add another item to.
Disruption This change is not disruptive. There are no API changes and without this fix there would be a UI change between D7 and D8.

When adding/editing an grouped exposed filter in the Views UI, the "Add another item" button is located in the wrong place. In this case, a picture *is* worth 1000 words...

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mikeker’s picture

The problem was drupal_render_children was rendering the Add another item button ahead of the table. The attached patch puts the button where it belongs.

mikeker’s picture

Issue summary: View changes

Added Beta eval.

mikeker’s picture

Status: Active » Needs review
mikeker’s picture

Issue summary: View changes
dawehner’s picture

Status: Needs review » Reviewed & tested by the community

OH, I wonder how those happened to be reordered

Its looks much better now!

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed b6e7d31 and pushed to 8.0.x. Thanks!

  • alexpott committed b6e7d31 on 8.0.x
    Issue #2394693 by mikeker: "Add another item" button in the wrong place...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.