Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 UTC on 18 March 2024, to get $100 off your ticket.
Beta phase evaluation
Issue category | Bug |
---|---|
Unfrozen changes | Unfrozen because it only changes markup. |
Prioritized changes | This falls under "usability and user experience improvements" in that the Add another item button is nowhere near the items it would add another item to. |
Disruption | This change is not disruptive. There are no API changes and without this fix there would be a UI change between D7 and D8. |
When adding/editing an grouped exposed filter in the Views UI, the "Add another item" button is located in the wrong place. In this case, a picture *is* worth 1000 words...
Comment | File | Size | Author |
---|---|---|---|
#1 | 2394693-1.png | 42.68 KB | mikeker |
#1 | 2394693-1_grouped-filters-add-another.patch | 686 bytes | mikeker |
add-another-location.png | 54.02 KB | mikeker |
Comments
Comment #1
mikeker CreditAttribution: mikeker commentedThe problem was
drupal_render_children
was rendering the Add another item button ahead of the table. The attached patch puts the button where it belongs.Comment #2
mikeker CreditAttribution: mikeker commentedAdded Beta eval.
Comment #3
mikeker CreditAttribution: mikeker commentedComment #4
mikeker CreditAttribution: mikeker commentedComment #5
dawehnerOH, I wonder how those happened to be reordered
Its looks much better now!
Comment #6
alexpottThis issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed b6e7d31 and pushed to 8.0.x. Thanks!