Last release: http://blog.jquery.com/2014/12/18/jquery-1-11-2-and-2-1-3-released-safar...

CommentFileSizeAuthor
#11 interdiff.txt165.45 KBdroplet
#11 jquery-2392887-11.patch336.68 KBdroplet
#7 jquery-2392887-7.patch336.54 KBdroplet
#5 jquery-2392887-5.patch336.53 KBdroplet
#2 jquery-2392887-2.patch251.25 KBdroplet
jquery.patch331.45 KBdroplet
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch, jquery.patch, failed testing.

droplet’s picture

droplet CreditAttribution: droplet commented
Status: Needs work » Needs review
FileSize
jquery-2392887-2.patch251.25 KB

Changed some testcases link to less changing files.

Status: Needs review » Needs work

The last submitted patch, 2: jquery-2392887-2.patch, failed testing.

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented

I think you forgot to add the jquery.min.js file in the patch.

droplet’s picture

droplet CreditAttribution: droplet commented
Status: Needs work » Needs review
FileSize
jquery-2392887-5.patch336.53 KB
nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
Status: Needs review » Needs work 
+++ b/core/core.libraries.yml
@@ -314,13 +314,13 @@ html5shiv:
+    assets/vendor/jquery/jquery.min.js: { weight: -20 }

Options should be { weight: -20, minified: true }.

droplet’s picture

droplet CreditAttribution: droplet commented
Status: Needs work » Needs review
FileSize
jquery-2392887-7.patch336.54 KB

Oh. never know it has this option. Added

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
Status: Needs review » Reviewed & tested by the community

It's only used to say that those files don't need to be minified again. Not really doing much right now as we don't have minification in core.

Tentatively marking RTBC, if testbot is green we're good. Stuff still works, views ui, quickedit, contextual, toolbar.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented

Is there any reason we are moving to a minified file here? Seems like that should be a separate discussion?

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented

See parent issue, we're updating and switching to minified in one go.

droplet’s picture

droplet CreditAttribution: droplet commented
Issue summary: View changes
Status: Reviewed & tested by the community » Needs review
FileSize
jquery-2392887-11.patch336.68 KB
interdiff.txt165.45 KB

new version:
http://blog.jquery.com/2014/12/18/jquery-1-11-2-and-2-1-3-released-safar...

Rerolled.

droplet’s picture

droplet CreditAttribution: droplet commented
Title: Update JS lib: jQuery to 2.1.1 » Update JS lib: jQuery to 2.1.3
nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
Status: Needs review » Reviewed & tested by the community

New version is all good too.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Let's have a new jquery to celebrate the season's festivities :)

We have a commitment to ship with the latest version of Drupal's dependencies on release. Committed a6dcf1b and pushed to 8.0.x. Thanks!

  • alexpott committed a6dcf1b on 8.0.x 
    Issue #2392887 by droplet: Update JS lib: jQuery to 2.1.3

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.