Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
#2386247: install.php should pass the class loader down into install_begin_request() introduced a backwards-compatibility layer to install_drupal()
to temporarily allow calling it without a class loader.
This was necessary because the testbot uses Drush to install Drupal.
Proposed resolution
As soon as that issue is committed, a corresponding fix to Drush is committed and Drush is updated on all test runners this backwards-compatibility layer should be removed.
Remaining tasks
User interface changes
API changes
Comment | File | Size | Author |
---|---|---|---|
#25 | 2389243_25.patch | 877 bytes | Mile23 |
#23 | 2389243-23.patch | 848 bytes | dawehner |
#9 | 2389243_6.patch | 1.46 KB | Mile23 |
#6 | interdiff.txt | 639 bytes | Mile23 |
#6 | 2389243_6.patch | 1.46 KB | Mile23 |
Comments
Comment #1
tstoecklerComment #2
tstoecklerCreated https://github.com/drush-ops/drush/pull/1051
Comment #3
tstoecklerI think this should work by now.
Comment #4
Mile23Reroll.
Encountered while trying to make this work: #2380389: Use a single vendor directory in the root
Comment #6
Mile23Missed one.
This leads to this rather interesting error in two tests when run in the UI:
Comment #7
joelpittet@Mile23 just to confirm: this patch in #6 breaks the simpletests in the UI?
Comment #8
Mile23Yes. That error for both
Drupal\Tests\simpletest\Functional\BrowserTestBaseTest::testGoTo
andDrupal\Tests\simpletest\Functional\BrowserTestBaseTest::testForm
.I couldn't track it down in the time I have to work on Drupal today.
Since we have two (yes, TWO) different ways of setting up the fixture Drupal for functional testing, I'm not surprised.
Comment #9
Mile23Reupload of #6 to see what happens on the new testbot.
Comment #10
joelpittetTagging for triage because it would be nice to get rid of this cruft during RC.
Comment #11
joelpittetThis seems to do the trick with the new Drupal CI
Comment #12
xjmI'm not comfortable with this BC break during RC (and it is a BC break, despite that the documentation does not explicitly support the older usage).
Comment #13
Mile23So improvements to tests are now off-limits for 8.0 release?
Comment #14
tim.plunkettThe second hunk can be moved to another issue. The first hunk is not in test code, but the installer, and is slated for 9.x
Comment #15
dawehnerI disagree to be honest. The installer is not an official runtime API, so for example applying this patch will not break ANY existing site.
Comment #16
catchYes I think we could treat the installer as @internal potentially. Moving back to a minor version for discussion at least.
Comment #22
joelpittetReopening
Comment #23
dawehnerReroll.
Comment #25
Mile23Another re-roll. The fact that the patch didn't apply is further evidence that we don't need the BC code. (It didn't apply because we changed the function arguments to support a native command-line installer.)
Comment #26
joelpittetAssuming this is @internal and it looks like Drush hasn't been using this for a while in the testing infra.
Comment #28
Mile23DrupalCI testing infra doesn't use Drush (for D8 anyway).
Comment #29
catchComment #31
catchLooked back over this. Drush was updated for the change in 2014, so I think this is fine to commit to a minor release. While it was introduced as a 'bc layer' this was a shim for a couple of months that never got updated rather than anything we expected code other than 2014-era drush to call.
Committed f9a3fa0 and pushed to 8.7.x. Thanks!