Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
How many times do I have to roll this patch? :P
Beta phase evaluation
Issue category | Bug because there is a small spelling error and inconsistency in the UI. (Config sync first says "synchronising" and then "synchronizing".) |
---|---|
Issue priority | Minor because it's really a very small typo. |
Unfrozen changes | Unfrozen because it only changes code comments and one UI string. |
Disruption | Not really. |
Proposed resolution
Spell it the American way as per our content guidelines.
Remaining tasks
@alexpott should add a git commit hook that checks his patches for "synchronis".
Task | Novice task? | Contributor instructions | Complete? |
---|---|---|---|
Update the patch to incorporate feedback from reviews in #3 and #4 | Novice | Instructions | |
Review patch to ensure that it fixes the issue (i.e. all instances of "synchronis*" outside the vendor directory), stays within scope, is properly documented, and follows coding standards | Yes | Instructions |
User interface changes
One string changes while configuration is being imported.
API changes
None.
Comment | File | Size | Author |
---|---|---|---|
#8 | interdiff.txt | 654 bytes | xjm |
#6 | drupal-serialis-2388925-6.patch | 6.96 KB | preshetin |
sssszzzz.patch | 6.55 KB | xjm | |
Comments
Comment #1
xjmComment #2
xjmComment #3
znerol CreditAttribution: znerol commentedConfigSync.php
contains serialising, should be fixed also.Comment #4
xjmThanks @znerol. I've confirmed that that is the only instance for "serialising":
Makes sense to add that to this patch as well. Adding a novice task to update the patch.
Comment #5
preshetin CreditAttribution: preshetin commentedComment #6
preshetin CreditAttribution: preshetin commentedComment #7
eidoscomIt seems that all is ok now :)
Comment #8
xjmThanks @preshetin and @eidoscom! Here is an interdiff between the initial patch and #6. (It's always helpful to provide an interdiff when updating an existing patch.)
Comment #9
alexpottCommitted a198ce6 and pushed to 8.0.x. Thanks!
Thanks for adding the beta evaluation for to the issue summary.
Comment #11
alexpottbtw. the British have not invaded config sync - they live in config sync - they just forgot to defer favourite English teachers.
[Editted for colourful use of language]