The shortcut module uses Test class members with underscored names. Some examples are big_user, web_user and admin_user, but there could be others. According to our coding conventions, these should be renamed to bigUser, webUser and adminUser. In addition, some properties are undefined but should be.

See the parent issue #1811638: [meta] Clean-up Test members - ensure property definition and use of camelCase naming convention.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task, because this is a coding standards change.
Issue priority Not critical because coding standard changes are not critical.
Unfrozen changes Unfrozen because it only changes automated tests.
Disruption There is no disruption expected from this sort of change.
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hussainweb’s picture

Skipping root_user in ShortcutLinksTest as that comes from WebTestBase in simpletest.

Status: Needs review » Needs work

The last submitted patch, 1: clean_up_shortcut-2388009-1.patch, failed testing.

hussainweb’s picture

Status: Needs work » Needs review
FileSize
831 bytes
7.48 KB

Another typo. :( I hope this works.

Mile23’s picture

The patch in #3 refactors class-level properties from under_score to camelCase as the coding standards demand.

I know this because I applied the patch, ran my own coding standards review with netbeansdrupalcomposed, and poked through all the test classes to find camel case and underscore violations.

Most importantly, the patch refactors properties of Drupal\shortcut\Tests\ShortcutTestBase and adds relevant @var annotation.

Mile23’s picture

Status: Needs review » Reviewed & tested by the community

Ugh. I meant to set this to RTBC in #4.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 5ed1ed8 and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation for to the issue summary.

  • alexpott committed 5ed1ed8 on
    Issue #2388009 by hussainweb: Clean-up shortcut module test members -...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.