Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
As per #2183983: Find hidden configuration schema issues field.value.datetime and field.value.link are recurring problems in migrate tests. Here is a quick test to prove this with one of them where we should fix it.
Proposed resolution
Fix them :)
Remaining tasks
Fix. Review. Commit.
User interface changes
None.
API changes
None.
Comment | File | Size | Author |
---|---|---|---|
#8 | 2386325-field-bugs-8.patch | 2.27 KB | Gábor Hojtsy |
#8 | interdiff.txt | 1.69 KB | Gábor Hojtsy |
#3 | 2386325-field-bugs-3.patch | 1.1 KB | Gábor Hojtsy |
#3 | interdiff.txt | 444 bytes | Gábor Hojtsy |
#1 | 2386325-field-bugs.patch | 682 bytes | Gábor Hojtsy |
Comments
Comment #1
Gábor HojtsyComment #3
Gábor HojtsyThe link one was easy, that is a misnamed item. The datetime item I could not yet figure out...
Comment #5
Wim LeersFor when you reroll this one to fix the failing tests:
Stupid whitespace problem :)
Comment #6
Gábor HojtsyCritical and D8 upgrade path based on #2183983: Find hidden configuration schema issues.
Comment #7
Gábor HojtsyAfter further discussion with @xjm and @effulgentsia, keeping at normal, but keeping the tag.
Comment #8
Gábor HojtsySo the detetime bug is very interesting... For one, the datetime defaults are defined as such:
This structure is extensively tested in \Drupal\datetime\Tests\DateTimeFieldTest. However, migrations attempt to create a simple 'value' key instead of these keys with the date values. That will never pass schema validation (or work as a date default for that matter).
Here is the fix.
Comment #9
effulgentsia CreditAttribution: effulgentsia commentedLooks good.
To clarify, what we thought made sense was that if #2183983: Find hidden configuration schema issues uncovers a bug that requires changes to the actual structure of config (meaning something in active config or code that writes to config would need to be updated), such as #2385805: Views tests don't pass strict schema checking, then that should be a critical, since we don't want to release Drupal with a known bug in its data structure. However, this issue merely uncovers changes needed to a schema file and a test, which can happen after release, so not critical.
Comment #10
alexpottThis issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed a029bf5 and pushed to 8.0.x. Thanks!