Spellchecking Drupal - Javascript

That works, thanks.

      // An entity instance ID. The first intance of a specific entity (i.e. with

in core/modules/quickedit/js/models/EntityModel.js

        // Remove all exisiting options from dropdown.

in core/modules/menu_ui/menu_ui.admin.js

// The form item containg the "Allowed HTML tags" setting.

in core/modules/filter/filter.filter_html.admin.js

if (!$link_title.data('menuLinkAutomaticTitleOveridden')) {

in core/modules/menu_ui/menu_ui.js - this patch converted all the other instances here - so this is likely to be introducing a bug.

@param String sstyles

in core/modules/ckeditor/js/ckeditor.stylescombo.admin.js

 * @param jQuery.Eevent event

I think this should be jQuery.Event in core/modules/quickedit/js/views/EntityToolbarView.js

// behaviors) are excuted before any timeout functions are called, so we

in core/modules/file/file.js

// Initialize after the current executation cycle, to make the AJAX

in core/modules/contextual/js/contextual.js

// - 'saving'or 'saved': don't do anything.

in core/modules/quickedit/js/views/AppView.js

// Remove the 'Add ' prefix from the button labels since they're being palced

in core/modules/views_ui/js/views-admin.js

       * by building the universe of potential values from the feature's require-
       * ments and then checking whether anything in the filter prevents that.

we don't hyphenate - in core/modules/editor/js/editor.admin.js

OK, this all looks good to me.

But because it is JavaScript, we have no automated tests. Some of the patch is just changing comments, but some of it is changing JavaScript function names or variable names, which could potentially cause problems or break functionality.

The changes to actual JS code are in:
core/modules/contextual/js/toolbar/models/StateModel.js
core/modules/menu_ui/menu_ui.js
core/modules/quickedit/js/models/EntityModel.js [this is changing the string returned by the function; no idea what that is used for, it doesn't look user-facing?]

I personally have no idea what any of this JS code does, but I guess it should be tested manually, and we should also make sure that all uses of it have corresponding changes?

@mgifford the bug that #3 would have introduced was fixed in #6

+++ b/core/modules/menu_ui/menu_ui.js
@@ -45,7 +45,7 @@
-            if (!$link_title.data('menuLinkAutomaticTitleOveridden')) {
+            if (!$link_title.data('menuLinkAutomaticTitleOverridden')) {

Given that I'm not 100% confident of the rtbc. I'm putting back to needs review and leaving a tell for _nod in IRC.

Also @mgifford rtbc'ing your own patches is against policy -see https://www.drupal.org/node/156119#rtbc

Review :
Most of the spelling errors are in comment line. Concerning those in the code, I verified that no one remains in code with wrong typo.

During this time views-admin.js has changed. I slightly rerolled patch #6

Forgot the interdiff..

I reviewed the latest patch and latest interdiff.

Note that this patch changes more than just documentation so it's no unfrozen during the beta. The changes I've highlighted below are the non-docs ones. However, misspelled variable names introduce fragility (which is a specific example we included in https://www.drupal.org/core/beta-changes#prioritized), and there isn't really any disruption from fixing the variable names in this patch, so this is a good change to make during the beta.

+++ b/core/modules/contextual/js/toolbar/models/StateModel.js
@@ -38,7 +38,7 @@
-        'reset remove add': this.countCountextualLinks,
+        'reset remove add': this.countContextualLinks,

+++ b/core/modules/menu_ui/menu_ui.js
@@ -36,29 +36,29 @@
-          $link_title.data('menuLinkAutomaticTitleOveridden', true);
+          $link_title.data('menuLinkAutomaticTitleOverridden', true);

+++ b/core/modules/quickedit/js/models/EntityModel.js
@@ -450,7 +450,7 @@
-        return "isCommiting is a mutex, hence only changes are allowed";
+        return "isCommitting is a mutex, hence only changes are allowed";

Per @alexpott's comment in #11, I also grepped to ensure there were no more instances of these misspellings after applying the patch:

[mandelbrot:maintainer | Tue 16:32:06] $ grep -r "countCountextualLinks" *
[mandelbrot:maintainer | Tue 16:34:26] $ grep -r "menuLinkAutomaticTitleOveridden" *
[mandelbrot:maintainer | Tue 16:34:59] $ grep -r "isCommiting" *

I also reviewed locally with git diff --color-words to ensure all the changes looked correct.