Problem/Motivation

As per #2317865-28: Config schema definitions for plugins aren't applied to their derivatives we should not quote types where inline colons are used if its now followed by whitespace. @alexpott on that issue and @dawehner in #2381973-53: View wizard creates 'invalid' views out of the box, missing plugin_ids, insecure permissions also prefer that style.

Proposed resolution

Remove the quotes.

Remaining tasks

Review. Commit.

User interface changes

None.

API changes

None.

CommentFileSizeAuthor
#4 2383633-remove-quoted-schema-keys-4.patch1.71 KBGábor Hojtsy
#1 2383633-remove-quoted-schema-keys.patch3.35 KBGábor Hojtsy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
FileSize
2383633-remove-quoted-schema-keys.patch3.35 KB
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Needs review » Postponed

Postponing for now on #2381973: View wizard creates 'invalid' views out of the box, missing plugin_ids, insecure permissions which removes several of these outright.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Postponed » Needs work

#2381973: View wizard creates 'invalid' views out of the box, missing plugin_ids, insecure permissions landed.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Needs work » Needs review
FileSize
2383633-remove-quoted-schema-keys-4.patch1.71 KB

Rerolled. Only 3 instances left.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

So much better!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

This can is not disruptive and to schema only. Committed 36122d4 and pushed to 8.0.x. Thanks!

  • alexpott committed 36122d4 on 8.0.x 
    Issue #2383633 by Gábor Hojtsy: Clean up in-line colon code style in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.