I was checking SensioLabs Code Analysis report about Drupal, and I saw there is a file with no UTF8 encoding in Drupal code base.

CommentFileSizeAuthor
#1 encode-copyright-txt-uft8-2382199-1.patch638 bytescorbacho
2014-11-26-niglp.jpg79.69 KBcorbacho
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

corbacho’s picture

corbacho CreditAttribution: corbacho commented
FileSize
encode-copyright-txt-uft8-2382199-1.patch638 bytes

The patch fixes the encoding.

corbacho’s picture

corbacho CreditAttribution: corbacho commented
Issue summary: View changes

Adding link to the report

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Active » Needs review
corbacho’s picture

corbacho CreditAttribution: corbacho commented
Status: Needs review » Reviewed & tested by the community

Safe to mark it RTBC, since it's a minor change?

chx’s picture

chx CreditAttribution: chx commented

Did anyone check MAINTAINERS.txt ? Can be in this issue, can be a followup.

corbacho’s picture

corbacho CreditAttribution: corbacho commented

@chx good question.

SensioLabs only reported this file.

I don't know exactly how SensioLabs detect them, but I run this command :
find . -type f | xargs -I {} bash -c "iconv -f utf-8 -t utf-16 {} &>/dev/null || echo {}" > utf8_fail

And the only non UTF8 text file I got was COPYRIGHT.TXT
The rest was png images, .ico, .git files and some compressed files.. it's normal that those contain non utf8 characters.

chx’s picture

chx CreditAttribution: chx commented

Odd. It seems MAINTAINERS.txt is correct and I can't even find any revision when it was incorrect although I'd have sworn it had this problem. Nevermind. Sorry for the noise.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Nice catch.

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 4440bd9 on 8.0.x 
    Issue #2382199 by corbacho: Encode COPYRIGHT.TXT with UTF-8

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.