Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Split off from #2368807: Remove special support for NULL values in FieldItemList
ItemList::setValue() does $item->setvalue($value)
FieldItemList::setValue() does $item->setvalue($value, FALSE)
According to @fago in #2368807-25: Remove special support for NULL values in FieldItemList, that is an oversight, both should do $item->setvalue($value, FALSE)
Comment | File | Size | Author |
---|---|---|---|
#1 | 2381777-ItemList_FieldItemList_setValue-1.patch | 2.37 KB | yched |
Comments
Comment #1
yched CreditAttribution: yched commentedOnce #2368807: Remove special support for NULL values in FieldItemList is done, this lets us turn FieldItemList::setValue() into mostly a parent call rather than a full code duplicate
Thus, patch is on top of that issue, and postponed on it.
Comment #2
yched CreditAttribution: yched commentedComment #3
yched CreditAttribution: yched commented#2368807: Remove special support for NULL values in FieldItemList is in.
Comment #4
yched CreditAttribution: yched commentedGreen.
Easy RTBC anyone ? @fago already approved in #2368807-25: Remove special support for NULL values in FieldItemList :-)
Comment #5
jibranThank you.
Comment #7
yched CreditAttribution: yched commentedGreen at home - bot fluke ?
Left a note in #2372855: Add content & config entity dependencies to views, which introduced the code that fails.
Comment #12
yched CreditAttribution: yched commentedThis makes no sense.
Re-test, hoping to get a different test client.
Comment #14
yched CreditAttribution: yched commentedOK, back to RTBC then.
Comment #15
alexpottLess duplicate code - nice. Reduces beta fragility. This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 37cdcf8 and pushed to 8.0.x. Thanks!