Edit Group membership of a user and changing the status

I found that og_role_grant() was not loading existing roles for non-active users. I changed the default $check_active flag for a call to og_get_user_roles() to FALSE, and the error appears to be fixed. This makes it load existing role records even if the user is not active. Then drupal_write_record does not try and overwrite them.

Can we add a simpleTest here as-well?

Here is a simpletest demonstrating the problem. When called on an existing membership that already has a role and is not in the active state, og_role_grant fails to detect the presence of the existing role, and tries to write another record. This should fail.

Here's the whole thing. This should pass.

The patch in #5 is working for me.

#5 resolves this issue.

Same problem when you switch status between "Active", to user status "blocked", the user status has been changed and the role is "unchecked" and cause an error.

I use this to patch problem :

function og_get_user_roles($group_type, $gid, $uid = NULL, $include = TRUE, $check_active = TRUE) {

  .....

  // Check if roles are overriden for the group.
  $query_gid = og_is_group_default_access($group_type, $gid) ? 0 : $gid;

  if ($check_active && $is_blocked) {
    //$roles[$identifier] = array();
    //return $roles[$identifier];

    $query = db_select('og_users_roles', 'ogur');
    $query->innerJoin('og_role', 'ogr', 'ogur.rid = ogr.rid');

    $rids = $query
      ->fields('ogur', array('rid'))
      ->fields('ogr', array('name'))
      ->condition('ogr.group_type', $group_type, '=')
      ->condition('ogr.group_bundle', $bundle, '=')
      ->condition('ogr.gid', $query_gid, '=')
      ->condition('ogur.uid', $uid, '=')
      ->condition('ogur.gid', $gid, '=')
      ->orderBy('rid')
      ->execute()
      ->fetchAllkeyed();
  }
  .....

@amitaibu - Anything further needed on this one? We've got a fix and a test.

#5 fixed the pdo exception.

Merged, thanks! (Sorry for the late merge, I tend to be a little more quicker when it's a PR to GitHub)

Awesome. Thanks!

There is an addition to this fix on github, specifically this issue/this PR.

The same issue persists when trying to change status back to active and assign an existing role to a currently blocked user.

#5 works for me. Thanks!