Clean-up Node module test members - ensure property definition and use of camelCase naming convention

There are more instances to fix:

$ egrep -rl '\$this\->[a-z]+_' core/modules/node/src/Tests/
core/modules/node/src/Tests//MultiStepNodeFormBasicOptionsTest.php
core/modules/node/src/Tests//NodeAccessBaseTableTest.php
core/modules/node/src/Tests//NodeAdminTest.php
core/modules/node/src/Tests//NodeRevisionPermissionsTest.php
core/modules/node/src/Tests//PagePreviewTest.php
core/modules/node/src/Tests//Views/FrontPageTest.php
core/modules/node/src/Tests//Views/NodeFieldFilterTest.php
core/modules/node/src/Tests//Views/NodeLanguageTest.php

Just a few things:

NodeAccessFieldTest, line 80: Missed a camelCase.

NodeRevisionsAllTest: No @var docblocks on the properties.

NodeTranslationUITest: testDisabledBundle(), line 208: Missed a camelCase.

OK then. Let's re-test since the patch is stale, and then it's off to RTBC land if it's green.

The patch in #7 refactors class-level properties from under_score to camelCase as the coding standards demand.

I know this because I applied the patch, ran my own coding standards review with netbeansdrupalcomposed, and poked through all the test classes to find camel case and underscore violations. I found a few that were mentioned in #9, but those are apparently out of scope for this issue.

+++ b/core/modules/node/src/Tests/NodeAccessBaseTableTest.php
@@ -30,6 +30,22 @@ class NodeAccessBaseTableTest extends NodeTestBase {
+  /**
+   * An array of nids that are found to be visible while testing.
+   *
+   * @var array
+   */
+  protected $nidsVisible = array();

@@ -147,11 +162,11 @@ function testNodeAccessBasic() {
+      $this->nidsVisible = array();
...
+        $this->nidsVisible[$matches[1]] = TRUE;

@@ -163,10 +178,10 @@ protected function assertTaxonomyPage($is_admin) {
+          $this->assertIdentical(isset($this->nidsVisible[$nid]), $should_be_visible, strtr('A %private node by user %uid is %visible for user %current_uid on the %tid_is_private page.', array(
...
+            '%visible' => isset($this->nidsVisible[$nid]) ? 'visible' : 'not visible',

This does not need to be class properties - it is only used with the scope of a single method.

Patch in #14 applies, passes the testbot, changes property names from underscore to camel case, and refactors $this->nidsVisible to a local variable as per #13.

Previous fail says: "Setup environment The testbot client is probably malfunctioning."

Running again.

A straight reroll did the trick.

Well I am not sure about this:

In FrontPageTest.php:

  /**
   * Tests the frontpage when logged in as admin.
   */
  public function testAdminFrontPage() {
    // When a user with sufficient permissions is logged in, views_ui adds
    // contextual links to the homepage view. This verifies there are no errors.
    \Drupal::service('module_installer')->install(array('views_ui'));
    // Login root user with sufficient permissions.
    $this->drupalLogin($this->root_user); // << See here
    // Test frontpage view.
    $this->drupalGet('node');
    $this->assertResponse(200);
    // Check that the frontpage view was rendered.
    $this->assertPattern('/class=".+view-frontpage/', 'Frontpage view was rendered');
  }

In NodeAccessViewGrantsCacheContextTest.php:

  protected function setUp() {
    parent::setUp();

    node_access_rebuild();

    // Create some content.
    $this->drupalCreateNode();
    $this->drupalCreateNode();
    $this->drupalCreateNode();
    $this->drupalCreateNode();

    // Create user with simple node access permission. The 'node test view'
    // permission is implemented and granted by the node_access_test module.
    $this->accessUser = $this->drupalCreateUser(array('access content overview', 'access content', 'node test view'));
    $this->noAccessUser = $this->drupalCreateUser(array('access content overview', 'access content'));
    $this->noAccessUser2 = $this->drupalCreateUser(array('access content overview', 'access content'));

    $this->userMapping = [
      1 => $this->root_user, // << See here
      2 => $this->accessUser,
      3 => $this->noAccessUser,
    ];
  }

Find for << See here in above code snippets.
I have tried changing root_user to rootUser, but the test is failing. Am I missing something obvious?

@subhojit777: The root_user is setup in WebTestBase and will have to be handled by #2382195: Clean-up simpletest module test members - ensure property definition and use of camelCase naming convention. You can't change it in this patch since it requires changing WebTestBase.php.

1. Did egrep -rl '\$this\->[a-z]+_[a-z_]+' core/modules/node/src/Tests/, and got this as output:

core/modules/node/src/Tests/Views/FrontPageTest.php
core/modules/node/src/Tests/NodeAccessViewGrantsCacheContextTest.php

From @hussainweb's comment in #24, I guess there is no problem with that.

2. Test passed in #22

3. Did manual review of the patch in #21, it looks good.

Hence RTBC :)

Looks like Alex has been committing others of these, so joining the club. :P

Committed and pushed to 8.0.x. Thanks!