The color module uses Test class members with underscored names. Some examples are big_user, web_user and admin_user, but there could be others. According to our coding conventions, these should be renamed to bigUser, webUser and adminUser. In addition, some properties are undefined but should be.

See the parent issue #1811638: [meta] Clean-up Test members - ensure property definition and use of camelCase naming convention.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task, because this is a coding standards change.
Issue priority Not critical because coding standard changes are not critical.
Unfrozen changes Unfrozen because it only changes automated tests.
Disruption There is no disruption expected from this sort of change.
CommentFileSizeAuthor
#4 clean_up_color_module-2379863-4.patch1.37 KBmglaman
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

cilefen’s picture

cilefen CreditAttribution: cilefen commented
Issue summary: View changes
cilefen’s picture

cilefen CreditAttribution: cilefen commented
Issue summary: View changes
cilefen’s picture

cilefen CreditAttribution: cilefen commented
Title: Clean-up color module test members to use camelCase naming convention » Clean-up color module test members - ensure property definition and use of camelCase naming convention
mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman commented
Status: Active » Needs review
FileSize
clean_up_color_module-2379863-4.patch1.37 KB

Only instance I could find in color was for $this->big_user, looks like admin_user was already converted.

subhojit777’s picture

subhojit777
he/him
Primary language Bengali
CreditAttribution: subhojit777 commented
Assigned: Unassigned » subhojit777
subhojit777’s picture

subhojit777
he/him
Primary language Bengali
CreditAttribution: subhojit777 commented
Assigned: subhojit777 » Unassigned
Status: Needs review » Reviewed & tested by the community

Code looks good and ColorTest passed.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 4d514be and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation for to the issue summary.

  • alexpott committed 4d514be on 8.0.x 
    Issue #2379863 by mglaman: Clean-up color module test members - ensure...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.