I noticed two issues in Views UI CSS, in the views_ui module and Seven theme.

First, #edit-displays-preview-controls has been removed, way back in #1104204: Separate preview and main UI to prevent wide previews from destroying UI, but there are some CSS rules still referencing it. Trying to re-apply those rules by changing them to #views-ui-preview-form broke the Views UI preview form, so it's best to remove them.

Second, views-ui-rearrange-filter-form is no longer used as form id, but a class. So, some CSS styles no longer applied in the Filter Criteria Rearrange Form. I changed the rules into using the class, and added screenshots:

Before changing ids to class
Before class fix

After changing ids to class
After class fix

CommentFileSizeAuthor
#5 Screen Shot 2014-11-30 at 15.08.01.jpg439.79 KBLewisNyman
#5 Screen Shot 2014-11-30 at 15.05.37.jpg534.77 KBLewisNyman
#5 Screen Shot 2014-11-30 at 15.01.00.jpg521.42 KBLewisNyman
#5 Screen Shot 2014-11-30 at 15.00.51.jpg498.86 KBLewisNyman
fix-views_ui-outdated-css.patch3.77 KBherom
after-id-to-class.png14.64 KBherom
before-id-to-class.png14.66 KBherom
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

herom’s picture

herom CreditAttribution: herom commented
Issue summary: View changes
BarisW’s picture

BarisW CreditAttribution: BarisW commented

Thanks, looks good. I can't see any visual differences. Patch looks good to go. +1

LewisNyman’s picture

LewisNyman
he/him
CreditAttribution: LewisNyman commented
Status: Needs review » Reviewed & tested by the community

From a code point of view this looks good, it's been manually tested so RTBC

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Needs review
Issue tags: +Needs manual testing

Since this is changing CSS outside of Seven, can we get verification that this continues to look right in Stark/Bartik?

LewisNyman’s picture

LewisNyman
he/him
CreditAttribution: LewisNyman commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs manual testing
FileSize
Screen Shot 2014-11-30 at 15.00.51.jpg498.86 KB
Screen Shot 2014-11-30 at 15.01.00.jpg521.42 KB
Screen Shot 2014-11-30 at 15.05.37.jpg534.77 KB
Screen Shot 2014-11-30 at 15.08.01.jpg439.79 KB

Here are some screenshots from Bartik and Stark:

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Great, thanks!

Committed and pushed to 8.0.x.

  • webchick committed dd3dae0 on 8.0.x 
    Issue #2377685 by LewisNyman, herom: Fix outdated CSS rules in Views UI

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.