Test that Comments field title does not show when there are no comments

Something easy to get the day started.

This patch works.

this patch will solve problem of showing comment title even if the comment does not exist..

Patch by @kaustubhb works as expected. Documentation is also added awesome. I have tested. See the screenshots.

If No comment

If comments

Thank you for the patch.

It was worked on during ghent, so let's leave that.
According to https://groups.drupal.org/node/447258 the tag should be SprintWeekend2015, no # sign.
Tags should be be separated with a comma, not a space.
And there is no tag #comment. The component is enough. Please do not make up new tags.

I'm not sure why the testbot did not pick up the patch. I'll try and request it report the results back to the issue.

Changing the status might help test bot to pick and test the patch.

Patch doesn't applies successfully. Requires reroll.

Seeing if attached patch helps.

From the submitted patch by @kaustubhb. Below line needs to be added as documentation.

+++ b/core/modules/comment/templates/field--comment.html.twig
@@ -13,6 +13,7 @@
  * - title_suffix: Additional title output populated by modules, intended to
  *   be displayed after the main title tag that appears in the template.
  * - comments: List of comments rendered through comment.html.twig.
+ * - comments.1: to show the comment tile if comments exist comment.html.twig.

Rest seems fine to me.

That's caused by #cache key that set in \Drupal\comment\Plugin\Field\FieldFormatter\CommentDefaultFormatter::viewElements()

This patch fixed it for me. Rather than writing the condition based on {{ comments.1}} i have made use of {{ comments.pager}} because pager is set only when there are more than one comments.

Find updated patch here

This patch fixed it for me. Rather than writing the condition based on {{ comments.1}} i have made use of {{ comments.pager}} because pager is set only when there are more than one comments.

That's could be tested that no "Comments" title displayed when there's no comments
Better to extend one of existing tests \Drupal\comment\Tests\CommentInterfaceTest

Adding the test as requested to check the comment title

The test passes probably because logged in user does not have the needed permission

Let's add a test and test the patch with new test

This looks good now

I'm not sure we really want to introduce this hack. I think we actually want to fix #953034: [meta] Themes improperly check renderable arrays when determining visibility, which would fix this too?

Doing that would mean you're no longer able to render individual children and then render the rest. So AFAIK it's only a work-around, not the recommended solution.

+++ b/core/modules/comment/templates/field--comment.html.twig
@@ -27,7 +27,7 @@
-  {% if comments and not label_hidden %}
+  {% if comments.pager and not label_hidden %}

+++ b/core/themes/classy/templates/field/field--comment.html.twig
@@ -45,7 +45,7 @@
-  {% if comments and not label_hidden %}
+  {% if comments.pager and not label_hidden %}

suppose we should add preprocess function to change "label_hidden" depending on presence of comment thread and comment form but taking into account field settings

Closed as duplicate #2513068: Comments heading should not display when comments are closed and empty.

So something else clearly resolved this.

Here's a re-roll of the test-only patch from #22 which now passes.

So I think new issue title and priority.

I can rtbc this, I only re-rolled #22
Couple of minor nit fixes

+1 rtbc, looks twig now processes label of the field right

Moar tests. Committed f7f70ff and pushed to 8.0.x. Thanks!