user_save has a parameter named $array.. this is possibly the worst parameter name ever, so I renamed it to $fields to more accurately reflect it's purpose.

CommentFileSizeAuthor
#7 user_save_parameter.patch7.39 KBbeeradb
#5 user_save_parameter_rename-237381-5.patch7.09 KBfloretan
#3 user_save_parameter_rename0.patch7.28 KBbeeradb
user_save_parameter_rename.patch7.2 KBbeeradb
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

floretan’s picture

floretan CreditAttribution: floretan commented

The only reason I have not to mark this as RTBC is because $fields might need to be changed again if fields make it into core. What about using $edit which is also used by other *_save() functions in core?

dmitrig01’s picture

dmitrig01 CreditAttribution: dmitrig01 commented
Status: Needs review » Needs work
beeradb’s picture

beeradb CreditAttribution: beeradb commented
Status: Needs work » Needs review
FileSize
user_save_parameter_rename0.patch7.28 KB

renamed $fields to $edit. I actually thought $fields might have been a poor choice last evening, but wasn't at a computer.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Needs review » Needs work

+ * The $user object for th$edite user to modify or add. If $user->uid is

If I wasn't in the middle of doing SoC stuff atm, I'd re-roll myself. :P

floretan’s picture

floretan CreditAttribution: floretan commented
FileSize
user_save_parameter_rename-237381-5.patch7.09 KB

It took me some time to figure out that the comment above was referring to a line in the patch... I first thought it was webchick writing in a hurry :-)

I'm not in the middle of SoC stuff, so here's a re-roll.

floretan’s picture

floretan CreditAttribution: floretan commented
Status: Needs work » Needs review
beeradb’s picture

beeradb CreditAttribution: beeradb commented
FileSize
user_save_parameter.patch7.39 KB

patch was stale, here's a re-roll

floretan’s picture

floretan CreditAttribution: floretan commented
Status: Needs review » Reviewed & tested by the community

Patch works and looks good.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Category: feature » bug

Still applies with offset.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Looks good, tests still work, better variable name. What is not to like? :P

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.