Found a simple typo on line 123 in core/modules/ckeditor/js/ckeditor.js

Variable is initialized:
saveCallack: null,

Everywhere else referred to as saveCallback

Patch to follow.

CommentFileSizeAuthor
#1 drupal-2372255-1.patch413 bytesamorsent
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

amorsent’s picture

amorsent CreditAttribution: amorsent commented
FileSize
drupal-2372255-1.patch413 bytes
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Priority: Normal » Minor
Status: Active » Reviewed & tested by the community
Issue tags: +Trivial patch of the month, +JavaScript

Hah! Great catch, thank you!

This doesn't cause any bugs because of the dynamic nature of JS. Declaring this correctly simply allows JS interpreters in browsers to execute this JS slightly more efficiently :)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Nice catch!

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 36adf94 on 8.0.x 
    Issue #2372255 by amorsent: ckeditor.js variable name typo

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.