getting 'This webpage has a redirect loop' error when i click on Reset button. Its happening to my custom view using exposed filter. Then i noticed even its happening to this page too: http:/XX/admin/content?status=All&type=page&title=&langcode=All&op=Reset

goto: www.simplytest.me and fire up drupal instance using 8.x beta2 .
-- Goto content
-- filter on anything
-- this will bring up reset
-- press - reset.

my thanks to simplytest.me!

CommentFileSizeAuthor
#6 interdiff.txt541 bytesolli
#6 2370313-6.patch1.42 KBolli
#2 2370313-2.patch1.39 KBolli
#2 2370313-test.patch840 bytesolli
#1 2370313-1.patch586 bytesolli
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

olli’s picture

olli CreditAttribution: olli commented
Version: 8.0.0-beta2 » 8.0.x-dev
Issue summary: View changes
Status: Active » Needs review
Issue tags: +VDC
FileSize
2370313-1.patch586 bytes

This seems to fix it.

olli’s picture

olli CreditAttribution: olli commented
FileSize
2370313-test.patch840 bytes
2370313-2.patch1.39 KB

This looks like the same fix as in #1826008: Exposed form reset doesn't work..

The last submitted patch, 2: 2370313-test.patch, failed testing.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Priority: Normal » Major

sounds pretty major to me

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented 
+++ b/core/modules/views/src/Plugin/views/exposed_form/ExposedFormPluginBase.php
@@ -327,6 +327,8 @@ public function resetForm(&$form, FormStateInterface $form_state) {
+
+    $form_state->setRedirect('<current>');
   }

One thing which d7 does as well is to reset the $form_state values ... did we considered to do this here?

olli’s picture

olli CreditAttribution: olli commented
FileSize
2370313-6.patch1.42 KB
interdiff.txt541 bytes

Something like this?

SpadXIII’s picture

SpadXIII CreditAttribution: SpadXIII commented
Status: Needs review » Reviewed & tested by the community

Looks good, setting to RTBC.
Reproduced the results on a local install of d8 beta4. Before the patch, resetting a filtered view was broken (redirect loop), after applying patch, everything was working great!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.0.x. Thanks!

  • webchick committed a48aa76 on 8.0.x 
    Issue #2370313 by olli: D8 - Exposed filter - "This webpage has a...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.