Problem/Motivation

#318975: Remove confirmation page after installation introduced some temporary code to install_finished() to output legacy markup that PIFR asserted to be there in order to verify a correct Drupal installation.

Since PIFR has moved to installing Drupal via Drush this is no longer necessary.

Although the markup is never visible to any Drupal user in the user interface it is shown when using drush site-install, which is annoying.

Proposed resolution

Remove the obsolete code.

Remaining tasks

User interface changes

None.

API changes

None.

CommentFileSizeAuthor
pifr-installer-assertion.patch739 byteststoeckler
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs review » Reviewed & tested by the community

Nice find.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Category: Task » Bug report
Status: Reviewed & tested by the community » Fixed

Unnecessary code like this is a bug not a task. This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per #2350615: [policy, no patch] What changes can be accepted during the Drupal 8 beta phase?. Committed 1d0e7c7 and pushed to 8.0.x. Thanks!

  • alexpott committed 1d0e7c7 on 8.0.x 
    Issue #2369197 by tstoeckler: Fixed Remove obsolete PIFR-specific markup...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.