Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
When bartik is configured to be the theme for node creation/editing the image upload widget in bartik has no border around it.
Beta phase evaluation
Issue category | Bug as the file field does not have any CSS styling in Bartik, other field form elements on content add/edit pages do. |
---|---|
Unfrozen changes | Unfrozen because it only changes CSS. |
Comment | File | Size | Author |
---|---|---|---|
#5 | Screen Shot 2014-11-28 at 15.33.33.png | 31.24 KB | emma.maria |
#5 | Screen Shot 2014-11-28 at 14.53.08.png | 85.68 KB | emma.maria |
#4 | 2368251-4.patch | 378 bytes | vermario |
#4 | 2368251-4_preview.png | 65.1 KB | vermario |
#1 | Screen Shot 2014-11-24 at 01.15.32.png | 49.93 KB | emma.maria |
Comments
Comment #1
emma.mariaI can confirm there is no border on image file uploads in Bartik.
Seven has a border like this on image file uploads.
I think we should replicate this in Bartik to tidy it up. There are styles for borders on inputs already in place, we just need to add the selector for file-uploads to this.
Comment #2
vermario CreditAttribution: vermario commentedWorking on this! :)
Comment #3
emma.mariaThanks @vermario, looking forward to seeing the results.
If you get stuck with something don't worry, just post what you have and we will all help you out :)
Comment #4
vermario CreditAttribution: vermario commentedHere is the one-liner patch. :-)
Screenshot:
Comment #5
emma.maria@vermario For your next patch can you look at the patch naming conventions https://www.drupal.org/patch/submit/#patch_naming. People sometimes swap the issue number and description around but it's important that all those items are in the patch name.
Also don't forget to un-assign from an issue when you set to Needs Review (I forget all the time) this is just incase people ignore the issue as they think you are reviewing it.
Thanks for working on this Mario, I've heard you are doing really well getting started with Core and it shows :)
Patch review:
The image file field now has a border around it and looks good, so much cleaner. The selector used also matches the general file field so both now look great. Win win.
I also reviewed the code and the CSS selector was added along with other fields that use the border style so no replication of CSS styles, so the code is all good too.
Setting to RTBC.
Comment #6
emma.mariaComment #7
emma.mariaComment #8
alexpottCommitted e89029c and pushed to 8.0.x. Thanks!
Thanks for adding the beta evaluation for to the issue summary.